Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarification regarding dropout in the multihead attention block #21

Open
anupsingh15 opened this issue Apr 7, 2024 · 0 comments
Open

Clarification regarding dropout in the multihead attention block #21

anupsingh15 opened this issue Apr 7, 2024 · 0 comments

Comments

@anupsingh15
Copy link

Hi @hkproj

Why do you add dropout to the attention scores (line 110 in model.py)? Shouldn't you discard the dropout in the multihead attention block because you already add a dropout (line 81) in the residual connection block?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anupsingh15