Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is slicing on $this correct? #308

Open
jkiddo opened this issue Dec 5, 2024 · 1 comment
Open

Is slicing on $this correct? #308

jkiddo opened this issue Dec 5, 2024 · 1 comment

Comments

@jkiddo
Copy link

jkiddo commented Dec 5, 2024

Shouldn't https://github.com/hl7ch/ch-core/blob/944e7bf370ef629d8d72f2bef1dc167da0b7d3b6/input/fsh/profiles-resources/CHCoreOrganization.fsh#L9C15-L9C41 have been system instead of $this?
@ziegm
Copy link
Collaborator

ziegm commented Dec 5, 2024

the background for $this was to be able to have also type as discriminator. but with an open slicing it would be possible anyway.
@jkiddo does it matter in this profile? would it make an difference for validation? do you know that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkiddo @ziegm