Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping a task when previewing is like skipping the assignment #77

Open
hltcoe-bot opened this issue Aug 7, 2020 · 4 comments
Open

Comments

@hltcoe-bot
Copy link
Collaborator

I did not expect it. I thought maybe I could look at several examples of tasks and then go back to the main page and accept the first one that I previewed.

If this is the desired behavior, I can document that on the help page.

Poster: Cash Costello id: 248

@hltcoe-bot
Copy link
Collaborator Author

The behavior you expected seems more desirable than the current behavior.

Poster: Craig Harman

@hltcoe-bot
Copy link
Collaborator Author

The preview skip code uses the same session variable to maintain the skips:

def skip_task(request, batch_id, task_id):
    """
    Skip to next task when previewing a task
    """
    _add_task_id_to_skip_session(request.session, batch_id, task_id)
    return redirect(preview_next_task, batch_id)

We would have to separate preview_next_task() from the _skip_aware_next_available_task_id() function. It could instead be replaced by a function that gets the next task after the one specified.

Poster: Cash Costello

@hltcoe-bot
Copy link
Collaborator Author

mentioned in issue #278

Poster: Craig Harman

@hltcoe-bot
Copy link
Collaborator Author

Ah. It’s great to finally understand what this is.

Poster: Paul McNamee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant