Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIV-3528 - temporarily ignored W3C HTML validation tests #78

Merged
merged 3 commits into from
Nov 5, 2018

Conversation

hosainnet
Copy link
Contributor

@hosainnet hosainnet commented Nov 5, 2018

To unblock build.

W3C HTML validator rules changes, preventing <h*> elements to be inside
<legend>. See hmcts/look-and-feel#100

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #DIV-3528

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

To unblock build.

W3C HTML validator rules changes, preventing <h*> elements to be inside
<legend>. See hmcts/look-and-feel#100
@qzhou-hmcts
Copy link
Contributor

Do you have a story to revert this change?

To unblock build.

W3C HTML validator rules changes, preventing <h*> elements to be inside
<legend>. See hmcts/look-and-feel#100
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview November 5, 2018 12:32 Inactive
@hosainnet
Copy link
Contributor Author

@qzhou-hmcts yes - DIV-3529

@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview November 5, 2018 12:35 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview November 5, 2018 12:54 Inactive
@vianvi vianvi merged commit ab88ece into master Nov 5, 2018
@vianvi vianvi deleted the DIV-3528_disable_w3c_tests branch November 5, 2018 13:37
iichr pushed a commit that referenced this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants