Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W3C error: <h*> not allowed inside <legend> #100

Open
hosainnet opened this issue Nov 5, 2018 · 0 comments
Open

W3C error: <h*> not allowed inside <legend> #100

hosainnet opened this issue Nov 5, 2018 · 0 comments

Comments

@hosainnet
Copy link
Contributor

It seems a new release of the W3C validator is not allowing h* elements to be inside legend elements (not clear if this was intentional as the changelog doesn't explicity mention it)

This is causing tests using the w3cjs library to fail while validating output from this library (e.g https://github.com/hmcts/look-and-feel/blob/master/templates/look-and-feel/components/fields.njk#L128)
hosainnet added a commit to hmcts/div-respondent-frontend that referenced this issue Nov 5, 2018
@hosainnet
DIV-3528 - temporarily ignored W3C HTML validation tests
8bef419 
To unblock build.

W3C HTML validator rules changes, preventing <h*> elements to be inside
<legend>. See hmcts/look-and-feel#100
hosainnet added a commit to hmcts/div-decree-nisi-frontend that referenced this issue Nov 5, 2018
@hosainnet
DIV-3528 - temporarily ignored W3C HTML validation tests
3dbe000 
To unblock build.

W3C HTML validator rules changes, preventing <h*> elements to be inside
<legend>. See hmcts/look-and-feel#100
This was referenced Nov 5, 2018
Merged
Merged
hosainnet added a commit to hmcts/div-respondent-frontend that referenced this issue Nov 5, 2018
@hosainnet
DIV-3528 - temporarily ignored W3C HTML validation legend error
ec45015 
To unblock build.

W3C HTML validator rules changes, preventing <h*> elements to be inside
<legend>. See hmcts/look-and-feel#100
hosainnet added a commit to hmcts/div-decree-nisi-frontend that referenced this issue Nov 5, 2018
@hosainnet
DIV-3528 - temporarily ignored W3C HTML validation legend error
8a45f48 
To unblock build.

W3C HTML validator rules changes, preventing <h*> elements to be inside
<legend>. See hmcts/look-and-feel#100
qzhou-hmcts pushed a commit to hmcts/div-decree-nisi-frontend that referenced this issue Nov 6, 2018
@hosainnet @qzhou-hmcts
DIV-3528 - temporarily ignored W3C HTML validation tests
8ab3e1a 
To unblock build.

W3C HTML validator rules changes, preventing <h*> elements to be inside
<legend>. See hmcts/look-and-feel#100
nsingamsetty pushed a commit to hmcts/div-decree-nisi-frontend that referenced this issue Nov 8, 2018
@qzhou-hmcts @nsingamsetty
DIV-3499 Fixed feedback url (#122)
8199a7d 
* DIV-3499 Fixed feedback url

* DIV-3528 - temporarily ignored W3C HTML validation tests

To unblock build.

W3C HTML validator rules changes, preventing <h*> elements to be inside
<legend>. See hmcts/look-and-feel#100

* Upgraded look-and-feel version to 1.19.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hosainnet