Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NickAkhmetov/Update to mui v6, switch theme references to use mui themes #44

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

NickAkhmetov/Update to mui v6, switch theme references to use mui themes #44

wants to merge 23 commits into from
+3,063 −1,588

Conversation

NickAkhmetov
Copy link
Collaborator

This PR

  • Updates MUI to v6.
  • Updates theming to use MUI themes.
  • Moves the top config items to the legend quadrant (temporarily, pending design updates from Tiffany)

Light theme:
image

Dark theme:
image

Remaining todos:

  • Set right click events to not bubble past the top container to avoid issues with jupyter
  • Adjust styling for context menu to match MUI styling and to use MUI theme
  • Ensure that measurements for axis tick labels are properly working in non-"top left" position
  • Add support for not providing width/height dimensions (i.e. responsively filling the allocated space)

@NickAkhmetov
update to mui v6, switch theme references to use mui themes
d135975
@NickAkhmetov
update legend section
9ed659b
@NickAkhmetov
Consolidate CellPopConfig to legend
394e90f
@NickAkhmetov
prevent right click event propagation out of component, add "onClick"…
af7f3ae 
… handler support if anyone does want to read those events
@NickAkhmetov
style context menu with MUI
dec4ee9
@NickAkhmetov
add auto-sizing based on parent
1f615a2
@NickAkhmetov
enforce resizing rules so that sections can't overlap
4aacfe7
@NickAkhmetov
add stripes to bars to improve visibility, improve tooltip appearance…
5048ce1 
…, fix expanded heatmap colors
@NickAkhmetov
adjust violin height
cf78a5e
@NickAkhmetov
violins take 2
736f00c
@NickAkhmetov
hide violin stroke
f972c1a
@NickAkhmetov
display labels for hubmap-loaded data
d8e87d5
@NickAkhmetov
improve metadata bar positioning for X axis, move controls back to to…
43db51d 
…p bar, add restore to default button
@NickAkhmetov
wip - adding zustand
ccfcc99
@NickAkhmetov
zustand migrations, cleanup type annotations
fa3af2a
@NickAkhmetov
Fix tooltip calculation
e8e537c
@NickAkhmetov
add temporal middleware, hook up boolean states to undo/restore to de…
d2b4997 
…fault buttons
@NickAkhmetov
wip
5003367
@NickAkhmetov
move axis ordering logic into data context, get "undo" to work with s…
819f211 
…orts
@NickAkhmetov
hook undo/redo up to data context
47506a9
@NickAkhmetov
Started plot controls drawer
a41867b
@NickAkhmetov
add row/column display controls to plotcontrols
a9443fd
@NickAkhmetov
fix context menu
881c6b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NickAkhmetov