Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more color legends and using distinct colors #87

Open
dominikglodzikhms opened this issue Feb 28, 2023 · 2 comments
Open

Adding more color legends and using distinct colors #87

dominikglodzikhms opened this issue Feb 28, 2023 · 2 comments

Comments

@dominikglodzikhms
Copy link
Collaborator

Having shown GosCan to some people who haven't seen before, I have heard requests to add legends and remove abbreviations.

In the linear view:
CNV -> copy number variants
LOH -> loss of heterozygosity
Indicate that green corresponds to gain and pink to LOH in the circular view.

@dominikglodzikhms
Copy link
Collaborator Author

Some comments from Dana playing with the browser

The legends on the overview of all tumors display indels and point mutations, which you, Dominik, mentioned are not available yet
The orange label that displays indels on the overview page, displays inversions on the single tumor page
Both Duplication (red) and Insertion (green) should be added to the overview and single tumor view legends

@sehilyi
Copy link
Member

sehilyi commented Mar 19, 2023

I used different colors for GAIN and LOH. This will also address the colorblind issue (i.e., our previous colors for GAIN and LOH were not colorblind-friendly, cc @ngehlenborg). Colors are taken from https://mikemol.github.io/technique/colorblind/2018/02/11/color-safe-palette.html

@dominikglodzikhms If you can confirm that the new colors look good, I will regenerate all the thumbnails.

New

Screenshot 2023-03-19 at 18 13 51

Screenshot 2023-03-19 at 18 13 55

Previous

Screenshot 2023-03-19 at 18 18 17

Screenshot 2023-03-19 at 18 18 22

@sehilyi sehilyi changed the title More legends Adding more color legends and using distinct colors Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants