Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALS-5052]: Update to use docker tomcat image #82

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

ramari16
Copy link
Contributor

No description provided.

@ramari16 ramari16 added enhancement New feature or request dependencies Pull requests that update a dependency file labels Sep 21, 2023

EXPOSE 8080
FROM tomcat:9-jre11-openjdk-slim
ADD hpds-war-1.0-SNAPSHOT.war /usr/local/tomcat/webapps/ROOT.war
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming this ROOT.war is important if your application is running on /. Figuring that out was most of this task

Copy link
Contributor

@Gcolon021 Gcolon021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramari16 ramari16 merged commit e8c62bc into release/0003 Sep 22, 2023
@ramari16 ramari16 deleted the feature/ALS-5052 branch September 22, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants