-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: build and use local copy of vizarr on mybinder #16
Conversation
@manics Thanks for the work, I think it's a good idea to think use a local copy of the static files. However, since mybinder itself relies on github, I wouldn't see relying on github pages as an issue. Are you thinking about supporting offline usage for local jupyter installation? In both cases, I would suggest using Besides mybinder, since windows support is still an issue with jupyter-server-proxy, PWA is a better alternative way to support local jupyter installation including Windows. Of course, that means the user need to load Viv from internet for the first time, but that shouldn't be an issue. Independent of offline use, supporting PWA will also allow the viewer loads faster when using, e.g. Cache-First strategy. |
My main motivation is to run development versions of vizarr on binder. For instance if you opened a vizarr PR you could demo the changes by giving a mybinder link to your branch. Otherwise you have to clone, build and run it locally. Offline support, and for restricted networks which limit outgoing traffic, is an additional benefit though. |
I see, for that we have been using Netlify, a few clicks setup and it will build sites for every PR, it can also post the preview url in the corresponding PR, example here: imjoy-team/kaibu#19 (comment) In the ImJoy plugin in MyBinder, you can use the preview url instead of the GitHub pages version. Like that you don’t even need to include the build assets in the repo for your Binder demonstration. |
Thanks for all the points made here. I'm definitely interested in both aspects of this PR: (1) offline caching via a service-worker, and (2) the ability to test builds of PRs. Vizarr was originally under my account and I was deploying with netlify to do exactly what @oeway described. It worked really well for development, and I'll try to see if I can get permissions with the current org to do it again. I'll look into making a service-worker for an offline mode. I've used a next.js plugin for this before |
Thanks both for your feedback. I'll close this for now. |
Currently
example/imjoy_plugin.py
relies on the externally hosted https://hms-dbmi.github.io/vizarrI thought I'd have a go at getting the notebook to use build vizarr from the local source and to run it.
At the moment this is just a hack on top of #15
Let me know if you think it's worth investing time in attempting to do it properly.