Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing sizing and position issues with Math.floor for dropdown #296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KalebLenfest
Copy link

When testing this library, I found that removing the Math.floor would get the correct size of the parent component, whereas with it would end up short in many cases both for width and left specifically

When testing this library, I found that removing the Math.floor would get the correct size of the parent component, whereas with it would end up short in many cases both for width and left specifically
@EmanuelDesarrollo
Copy link

I have to stick to a design where the dropdown list and container list need to be synchronized on the same border, I never found the solution with props. When researching in the library I discovered the same thing as @KalebLenfest, the Math.floor property affects the correctness of the elements, in the attached image you can see the difference.

Usually with Math.floor():
media_20241122_110045_8172241661631911541

After the change, remove Math.floor():
media_20241122_110045_113654259456071237

Please accept the change sent by @KalebLenfest , thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants