Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors of sender names in group chats differ from member list #69

Open
ttlmax opened this issue Apr 15, 2022 · 10 comments
Open

Colors of sender names in group chats differ from member list #69

ttlmax opened this issue Apr 15, 2022 · 10 comments

Comments

@ttlmax
Copy link
Contributor

ttlmax commented Apr 15, 2022

While the entries in a group chat's member list are shown in different colors, the sender's name in the chat messages are all shown in the same color (some dark yellow for me).

I have no idea why pidgin is probably not able to get the color for the sender of the message from the related user in the members list as it is the case in chats with other protocols. Is there something that is missing in the plugin?

@hoehermann
Copy link
Owner

I confirm that outgoing and synced messaged are displayed in arbitrary colors.

For incoming messages however, it looks stable to me. I added all the people I chat with to my buddy list. Maybe that is needed for some mapping.

Though my options to test this behaviour are rather limited. I only have one phone and one emulated device. Quite possible that it looks okay if there are just two people in the chat room. :/

@ttlmax
Copy link
Contributor Author

ttlmax commented Apr 18, 2022

That's interesting. I can see different colors for the buddies (and the message time) in ordinary conversation (incoming name red, outgoing name blue). But in group chats, all names are displayed in some ochre yellow, ignoring the buddy's color in the member list

@hoehermann
Copy link
Owner

hoehermann commented Apr 18, 2022

color
"Works for me." 🤷

@ttlmax
Copy link
Contributor Author

ttlmax commented Apr 18, 2022

Indeed, that looks as expected, thanks for the screenshot. Then I'll have to go through my preferences and check which of them might change the colors as a side effect.

@ttlmax
Copy link
Contributor Author

ttlmax commented Apr 21, 2022

Found the issue. The color of each user in a group chat turns to ochre yellow when the option Receive notifications for all group messages is activated. This functionality is implemented by faking that the user's nick is mentioned in each incoming message. Obviously this also changes the color of the sender's name.

@hoehermann
Copy link
Owner

hoehermann commented Apr 21, 2022

Nice catch. This feature was introduced by 296016d. I never used it myself. Apart from this side-effect, does the feature work as intended for you?

@ttlmax
Copy link
Contributor Author

ttlmax commented Apr 22, 2022

I saw this in another plugin (I think it was matrix). It makes pidgin's tray icons to indicate a new message which is otherwise not the case for chats. But I am really wondering if this feature is sufficiently important compared to loosing user name colors in chat windows.

@hoehermann
Copy link
Owner

By default, the feature is disabled. I want to document the side-effect in the readme. Everything else is an end-user-decision. :)

@hoehermann
Copy link
Owner

hoehermann commented Jul 17, 2022

This issue has arisen again in the dev-branch. Affects outgoing messages (sent locally or remotely and synced). Incoming messages from others seem to be fine.

@hoehermann hoehermann reopened this Jul 17, 2022
@hoehermann
Copy link
Owner

It is now possible to use your UUID as a username in Pidgin. This way, everyone is identified by their UUID, including the local user. Although unwieldy, this seems to resolve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants