Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the checkboxes to Types::BOOLEAN to help keep the size of the database “row size” small #35

Open
grummbeer opened this issue Sep 23, 2024 · 2 comments

Comments

@grummbeer
Copy link
Contributor

A few days ago I run into the "Row Size Too Large" error [1]. Contao has changed all checkboxes to Types::BOOLEAN[2].

contao-navigation also uses some checkboxes. If you think it is a good idea to reduce the row size, I would create a PR for it.

[1] https://mariadb.com/kb/en/troubleshooting-row-size-too-large-errors-with-innodb/
[2] contao/contao#4797

@grummbeer grummbeer changed the title Convert Checkboxes to Types::BOOLEAN to help reducing the database row size Convert the checkboxes to Types::BOOLEAN to help keep the size of the database “row size” small Sep 23, 2024
@dmolineus
Copy link
Collaborator

Yes, it's a good idea. Internally the fields will be created as tinyint fields though. Therefore we have to ensure that strict type handling would not break anything. Be aware that Contao 4.13 and 5 work differently here. Contao 5.3 has a type handling which will create booleans from the doc block types.

@grummbeer
Copy link
Contributor Author

Thanks for the hint, I'm not that familiar with contao yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants