Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test runner for the holiday definitions #118

Closed
iGEL opened this issue Jan 24, 2019 · 3 comments
Closed

Add a test runner for the holiday definitions #118

iGEL opened this issue Jan 24, 2019 · 3 comments

Comments

@iGEL
Copy link
Contributor

iGEL commented Jan 24, 2019

I think it would be useful to run the tests defined in the definitions in this repository together with the rspec test suite. It would enable the authors to easily test their definitions and would also make the result visible in the PRs.

This probably requires to copy quite some code from the holidays gem, but I think it'll be worth it.

@ppeble
Copy link
Member

ppeble commented Jan 24, 2019

This is an excellent idea! We do have an issue for this specific thing but looking at it now I can see how it's not really clear to someone who is not deeply invested already in these repos. 😄

The other issue is #42. Once I get back from my trip (and get over my jet lag) I will look into this again and figure out how I want to combine these two and make them more clear.

The other issue: #42

@iGEL
Copy link
Contributor Author

iGEL commented Jan 24, 2019

Ah, sorry. I should have checked.

@iGEL iGEL closed this as completed Jan 24, 2019
@ppeble
Copy link
Member

ppeble commented Jan 24, 2019

It's okay! I am glad you did this because it shows that I should get my head back into it. I thought that I was the main person looking for it so it's nice to know that someone else also thinks it's a good thing for us to invest our time in. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants