Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

the hashing algorithm should not be hardcoded to SHA2256 #104

Open
thedavidmeister opened this issue Jul 3, 2018 · 5 comments
Open

the hashing algorithm should not be hardcoded to SHA2256 #104

thedavidmeister opened this issue Jul 3, 2018 · 5 comments

Comments

@thedavidmeister
Copy link
Contributor

the golang version allowed the hashing algorithm to be configurable in the DNA

currently the rust version is hardcoded to SHA2256 in the source chain (e.g. Entry and Header)

this should be correctly parameterised so that the DNA configuration works correctly
@thedavidmeister thedavidmeister mentioned this issue Jul 3, 2018
Merged
@thedavidmeister
Copy link
Contributor Author

relevant discussion #102 (comment)

screen shot 2018-07-04 at 10 38 12 am

@thedavidmeister
Copy link
Contributor Author

@zippy annoyingly, it looks like github doesn't auto link comments when you leave them on a PR :(

#102 (comment)

@zippy
Copy link
Member

zippy commented Jul 4, 2018

This is probably cross-repo issues where we had one number in org and another in holochain-rust?

@thedavidmeister
Copy link
Contributor Author

nah, same repo, but the comment was part of a PR review

@jamesray1
Copy link
Contributor

[F8-enhancement] M4-core P7-nicetohave

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zippy @thedavidmeister @jamesray1