Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): add env variable for oidc-name-attribute-overwrite #1850

Merged
merged 2 commits into from
Jan 4, 2025
Merged

feat(auth): add env variable for oidc-name-attribute-overwrite #1850

merged 2 commits into from
Jan 4, 2025

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes #1830

@Meierschlumpf Meierschlumpf added the enhancement New feature or request label Jan 3, 2025
@Meierschlumpf Meierschlumpf self-assigned this Jan 3, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner January 3, 2025 22:01
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Jan 3, 2025 •
edited
Loading

Here's the code health analysis summary for commits 2358f6f..ac31f98. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.52% 7944 / 36909
🔵 Statements 21.52% 7944 / 36909
🔵 Functions 24.76% 288 / 1163
🔵 Branches 61.59% 863 / 1401
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/auth/env.mjs 57.01% 20% 100% 57.01% 12-21, 32-46, 53-57, 70-78, 82-94
packages/auth/events.ts 96.58% 83.33% 100% 96.58% 50-51, 131-132
packages/auth/providers/oidc/oidc-provider.ts 16.66% 75% 50% 16.66% 9-38, 46-47
Generated in workflow #4487 for commit ac31f98 by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf marked this pull request as draft January 3, 2025 22:37
@Meierschlumpf Meierschlumpf marked this pull request as ready for review January 4, 2025 14:53
manuel-rw
manuel-rw approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@manuel-rw manuel-rw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the docs, the unraid docker template and the helm chart

@Meierschlumpf Meierschlumpf merged commit c349bf8 into dev Jan 4, 2025
13 checks passed
@Meierschlumpf Meierschlumpf deleted the oidc-name-attribute-overwrite branch January 4, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-rw manuel-rw manuel-rw approved these changes

Assignees

@Meierschlumpf Meierschlumpf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add AUTH_OIDC_NAME_CLAIM env variable
2 participants
@Meierschlumpf @manuel-rw