Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stacked dynamic sections menu #1184

Closed
wants to merge 5 commits into from
Closed

fix: stacked dynamic sections menu #1184

wants to merge 5 commits into from

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Sep 25, 2024 •
edited
Loading


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes #962

@Meierschlumpf Meierschlumpf changed the title wip: fix stacked dynamic sections menu fix: stacked dynamic sections menu Sep 25, 2024
@Meierschlumpf Meierschlumpf self-assigned this Sep 25, 2024
@Meierschlumpf Meierschlumpf added the bug Something isn't working label Sep 25, 2024
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Sep 25, 2024 •
edited
Loading

Here's the code health analysis summary for commits f8c21f6..c2ddb67. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 8 occurences introduced
View Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 38.45% 14655 / 38107
🔵 Statements 38.45% 14655 / 38107
🔵 Functions 35.74% 381 / 1066
🔵 Branches 70.76% 1302 / 1840
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/nextjs/src/components/board/sections/dynamic-section.tsx 0% 0% 0% 0% 1, 4-8, 14-15, 17-30, 32-37, 39
apps/nextjs/src/components/board/sections/dynamic/dynamic-context.tsx 0% 0% 0% 0% 1, 4, 7, 13-15, 21-23, 25-28, 30, 32-34, 41-48, 51-52, 54
apps/nextjs/src/components/board/sections/dynamic/dynamic-menu.tsx 0% 0% 0% 0% 1-5, 7-8, 11-13, 15-28, 30, 32-46, 48-65, 67-77, 79, 81-87, 89, 91-92, 99-103, 105-107, 109-113, 115-120, 122, 124-137, 139-148, 150
apps/nextjs/src/components/board/sections/menu/section-menu-context.tsx 0% 0% 0% 0% 1-2, 25-27
apps/nextjs/src/components/board/sections/menu/section-menu-dropdown.tsx 0% 0% 0% 0% 1, 3-4, 6, 22-24, 26-32, 34-42, 44-46, 48
apps/nextjs/src/components/board/sections/menu/section-menu-item.tsx 0% 0% 0% 0% 1, 12-14, 38, 40-45, 47-51, 53-56, 58-60, 62-70, 72-80, 83-86, 88-90, 92-106, 108-109, 111
apps/nextjs/src/components/board/sections/menu/section-menu-target.tsx 0% 0% 0% 0% 1-2, 4, 14-16, 18-19, 21-25, 27, 30-32, 34-40, 42
apps/nextjs/src/components/board/sections/menu/section-menu.tsx 0% 0% 0% 0% 1, 3-4, 6-7, 31-32, 34-41, 43-50, 52-58, 60-65, 67-73, 75-76, 78-80, 82-101, 103-111, 113-115, 117
Generated in workflow #3414 for commit c2ddb67 by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf force-pushed the dev branch 2 times, most recently from 09ac2bf to c37a0e3 Compare October 23, 2024 15:30
@Meierschlumpf
Copy link
Member Author

Mantine does not support nested menus, so I'll leave this for now. It's usable so IMO it's okay to leave it like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Meierschlumpf Meierschlumpf

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: item and dynamic section menus overlap
1 participant
@Meierschlumpf