Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain errors to be more transparent to the error source #21

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

miaucl
Copy link
Contributor

@miaucl miaucl commented Aug 12, 2024

Currently we only raise OpendataTransport(Connection)Error without any context. Therefore, we cannot understand where the error comes from (for example: Rate Limit just says Timeout but not why).

This is helpful when showing the error to the end user in for example home assistant.

@polgarc
Copy link
Contributor

polgarc commented Aug 20, 2024

Looks good. On a slightly different note, my change in #18 was merged but never released. I tried to contact @fabaff in comment and email but never got a reply - how can we release a new version with our changes?

@miaucl
Copy link
Contributor Author

miaucl commented Aug 21, 2024

@polgarc My changes last year have been published as a new version, but I would be great to have your and my PR merged into a new version. @fabaff Are you still reactive for this library?

@miaucl
Copy link
Contributor Author

miaucl commented Aug 21, 2024

If it is not the case, we don't have a way to release a new version apart from "creating" a new package which I would prefer not to do.

@miaucl
Copy link
Contributor Author

miaucl commented Sep 24, 2024

Any advancements related to this PR?

@fabaff
Copy link
Member

fabaff commented Sep 27, 2024

Ups, sorry missed the notification..

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fabaff fabaff merged commit 0fb532a into home-assistant-ecosystem:master Sep 27, 2024
3 checks passed
@miaucl
Copy link
Contributor Author

miaucl commented Sep 27, 2024

Would it be ok to release a 0.5.0 version? @fabaff

@miaucl
Copy link
Contributor Author

miaucl commented Sep 27, 2024

@fabaff I have seen you tried to release the version 0.5.0, but the actions failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants