Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fahrenheit to celsius rounded to one digit #37

Open
PoppyPop opened this issue Nov 20, 2022 · 2 comments
Open

Fahrenheit to celsius rounded to one digit #37

PoppyPop opened this issue Nov 20, 2022 · 2 comments

Comments

@PoppyPop
Copy link

PoppyPop commented Nov 20, 2022

Hello,

Is there any reason that you round the celsius convertion to one digit ?
And more generally for all the convertion ?

If there is no reason, i can make a pull request to pass it to 2 digit.

The code :

def _ftoc(fahrenheit: float | str) -> float:
    """Convert f to c."""
    return round(meteocalc.Temp(fahrenheit, "F").c, 1)
@pvizeli
Copy link
Member

pvizeli commented May 4, 2023

I think the best solution would be not doing any conversation and let home assistant core handle it

@pvizeli
Copy link
Member

pvizeli commented Feb 8, 2024

I close this as the next big update on this library will move all conversation out into core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants