Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Color Temperature to Hue Accessory #119

Open
apartmedia opened this issue Jul 10, 2021 · 8 comments
Open

Add Color Temperature to Hue Accessory #119

apartmedia opened this issue Jul 10, 2021 · 8 comments

Comments

@apartmedia
Copy link

On latest gui (4.0.69) the color picker can not be placed to center (white).
Tested with iPadPro iOS 14.6 Mobile Safari, Mobile Firefox and MacBookPro macOS Big Sur 11.4 Chrome Desktop 91.0.4472.114
See attached video...

HOOBSReplay.mov
@mkellsy
Copy link
Contributor

mkellsy commented Jul 10, 2021

I was able to do it. It shows as grey, but I am able to center it. I think what we need is to add the color temp section for this accessory.

You got hue, brightness and then temperature, that shows 4 options, which includes white.

The video because it won't play in GitHub.

@mkellsy mkellsy changed the title No center (white) placement possible on Color Picker Add Color Temperature to Hue Accessory Jul 10, 2021
@apartmedia
Copy link
Author

apartmedia commented Jul 13, 2021

I was able to do it. It shows as grey, but I am able to center it. I think what we need is to add the color temp section for this accessory.

You got hue, brightness and then temperature, that shows 4 options, which includes white.

The video because it won't play in GitHub.

Could you watch the video what happens when using the color picker on my touch device? Or do you need it in a different format as you say it won’t play (although I can play mov in GitHub with Safari 🤔).
It might behave different or even work when using a mouse.

@mkellsy
Copy link
Contributor

mkellsy commented Jul 13, 2021

What I’m saying is the hue accessory needs some work. One of the things that is needed is a mobile friendlier color wheel. The color balance method is that. (It’s the same method that HomeKit uses)

@apartmedia
Copy link
Author

might this be a solution for better mobile and touch usage while keeping the design (if that’s one goal)?
iro.js
Not sure if this is Vue compatible though…

@mkellsy
Copy link
Contributor

mkellsy commented Jul 13, 2021

That's exactly what we are using.

https://github.com/hoobs-org/gui/blob/main/package.json

"@jaames/iro": "^5.3.1",

@apartmedia
Copy link
Author

apartmedia commented Jul 14, 2021

Ok, that should be normally fine for touch devices,
The codepen demos linked on the iro site worked flawless for me on mobile Safari in iOS and iPad OS.

@mkellsy
Copy link
Contributor

mkellsy commented Jul 14, 2021

Codepen doesn't show the whole story. The issue is the select and revert to the default display.
It needs a slight delay and debounce, so you can adjust the color, and it won't revert until input stops.

Sounds confusing, but remember JavaScript if fast, it's timed in milliseconds.

I am also using this task to complete the hue accessory.

@apartmedia
Copy link
Author

I‘m with you… JS: powerful and guilty 😉
Let me know if I can be helpful by testing something.
Regarding the hue accessory u r planning to use the same lib?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants