Feat/10 board - 게시판 entity , repo 작성 #20

lgsok00 · 2023-10-10T01:46:59Z

게시판 entity, repo 작성 완료했습니다.

.

bongsh0112

고생하셨습니다
수정사항 확인해주세요

bongsh0112 · 2023-10-10T02:07:57Z

src/main/java/HookKiller/server/board/controller/ArticleController.java

+
+  private final ArticleService articleService;
+
+  @GetMapping("{/boardId}")


@GetMapping("/{boardId}")
가 맞지 않을까요..?

맞지 {/boardId}는 좀 너무했다

bongsh0112 · 2023-10-10T02:09:18Z

src/main/java/HookKiller/server/board/entity/Article.java

+    private Long createdUser;
+    private Long updatedUser;


create 혹은 update한 User의 Id를 쓰는거면
createdUserId와 같은 방식으로 쓰는게 좋겠네요

bongsh0112 · 2023-10-10T02:09:51Z

src/main/java/HookKiller/server/board/entity/Article.java

+    private String orgArticleLanguage;
+    private String articleType;
+    private String status;
+    private int likeCount;


혹시 likeCount 업데이트는 어떻게 진행되나요?
좋아요 누르면 이 값이 업데이트 되어야 할텐데요

bongsh0112 · 2023-10-10T02:11:07Z

src/main/java/HookKiller/server/board/service/BoardService.java

+        List<Board> boardList = boardRepository.findAll();
+        List<BoardDto> boardDtoList = new ArrayList<>();
+//        boardDtoList = boardList.stream().map().toList();
+        return boardDtoList;


우선 빈 리스트만 리턴하도록 해놓은 것 맞나요

bongsh0112 · 2023-10-10T02:11:53Z

src/main/java/HookKiller/server/board/service/ArticleService.java

+    // boardId로 board에 해당하는 Article들을 모두 뽑아온다
+    // Article들 하나하나마다에 해당하는 ArticleContent랑 같이 DTO로 변환한다
+    // 변환된 DTO들을 모아놓은 list를 리턴한다
+    return articleRepository
+            .findAllByBoard(boardRepository.findById(boardId).orElseThrow(() -> ExampleException.EXCEPTION))
+            .stream().map(article -> ArticleDto.of(article, articleContentRepository.findByArticleAndLanguage(article, language).orElseThrow(() -> ExampleException.EXCEPTION)))
+            .toList();
+  }


주석에 따라 혼자서 다시 작성해보세요

bongsh0112 · 2023-10-10T02:15:26Z

src/main/java/HookKiller/server/board/entity/Article.java

+    @JoinColumn(name="board_id")
+    private Board board;
+
+    @OneToMany


@OneToMany(mappedBy = ~~~)에 대해
공부해보시고 수정 바랍니다

bongsh0112 · 2023-10-10T02:15:31Z

src/main/java/HookKiller/server/board/entity/Article.java

+    @OneToMany
+    private List<ArticleLike> ArticleLike;
+
+    @OneToMany


@OneToMany(mappedBy = ~~~)에 대해
공부해보시고 수정 바랍니다

bongsh0112 · 2023-10-10T02:15:36Z

src/main/java/HookKiller/server/board/entity/Article.java

+    @OneToMany
+    private List<ArticleContent> articleContent;
+
+    @OneToMany


@OneToMany(mappedBy = ~~~)에 대해
공부해보시고 수정 바랍니다

bongsh0112 · 2023-10-10T02:16:03Z

src/main/java/HookKiller/server/board/entity/ArticleContent.java

+    @JoinColumn(name="article_id")
+    private Article article;
+
+    private String language;


LanguageType이라는 이넘을 만드신 걸로 아는데
혹시 이건 어떤 필드인가요

bongsh0112 · 2023-10-10T02:16:47Z

src/main/java/HookKiller/server/board/entity/Reply.java

+    @JoinColumn(name="article_id")
+    private Article article;
+
+    @OneToMany


마찬가지로 mappedBy를 사용해보세요

donsonioc2010

일단 바꿔오세욧

donsonioc2010 · 2023-10-10T05:15:18Z

src/main/java/HookKiller/server/board/controller/ArticleController.java

+
+  private final ArticleService articleService;
+
+  @GetMapping("{/boardId}")


맞지 {/boardId}는 좀 너무했다

donsonioc2010 · 2023-10-10T05:15:58Z

src/main/java/HookKiller/server/board/controller/BoardController.java

+import lombok.RequiredArgsConstructor;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Controller;
+import org.springframework.web.bind.annotation.*;


import org.springframework.web.bind.annotation.*;
는 실제 참조하는 메소드로 변경해주세요.

donsonioc2010 · 2023-10-10T05:16:58Z

src/main/java/HookKiller/server/board/entity/Article.java

+package HookKiller.server.board.entity;
+
+import HookKiller.server.common.AbstractTimeStamp;
+import jakarta.persistence.*;


import jakarta.persistence.*를 참조하는 메소드로 수정바람

donsonioc2010 · 2023-10-10T05:17:03Z

src/main/java/HookKiller/server/board/entity/ArticleContent.java

+package HookKiller.server.board.entity;
+
+
+import jakarta.persistence.*;


import jakarta.persistence.*를 참조하는 메소드로 수정바람

donsonioc2010 · 2023-10-10T05:17:08Z

src/main/java/HookKiller/server/board/entity/ArticleLike.java

+
+
+import HookKiller.server.common.AbstractTimeStamp;
+import jakarta.persistence.*;


import jakarta.persistence.*를 참조하는 메소드로 수정바람

donsonioc2010 · 2023-10-10T05:22:01Z

src/main/java/HookKiller/server/board/exception/GlobalException.java

+
+@Getter
+@AllArgsConstructor
+public enum GlobalException implements BaseErrorCode {


BoardExceptions로 따로 뺴기 바람. GlobalException은 이미 사용중이니..

donsonioc2010 · 2023-10-10T05:22:20Z

src/main/java/HookKiller/server/board/repository/ArticleRepository.java

+
+import java.util.List;
+
+@Repository


필요없음.

donsonioc2010 · 2023-10-10T05:22:24Z

src/main/java/HookKiller/server/board/repository/BoardRepository.java

+ * Spring Data JPA를 사용하여 기본 CRUD 작업을 자동으로 처리합니다.
+ */
+
+@Repository


필요없음.

donsonioc2010 · 2023-10-10T05:22:26Z

src/main/java/HookKiller/server/board/repository/ReplyContentRepository.java

+import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.stereotype.Repository;
+
+@Repository


필요없음.

donsonioc2010 · 2023-10-10T05:22:31Z

src/main/java/HookKiller/server/board/repository/ReplyRepository.java

+import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.stereotype.Repository;
+
+@Repository


필요없음.

donsonioc2010

@lgsok00 @lljh1992 윙크

donsonioc2010 · 2023-10-12T07:02:49Z

build.gradle

@@ -72,6 +72,9 @@ dependencies {
    // IAMPORT
    implementation 'com.github.iamport:iamport-rest-client-java:0.2.23'

+    // WebClient
+    implementation "org.springframework.boot:spring-boot-starter-webflux"


제거하시기 바랍니다.

donsonioc2010 · 2023-10-12T07:03:35Z

src/main/java/HookKiller/server/board/controller/ArticleController.java

+
+@Slf4j
+@RestController
+@RequestMapping("/articles")


이게 좀 더 어울리지 않을까요?

Suggested change

@RequestMapping("/articles")

@RequestMapping("/article")

donsonioc2010 · 2023-10-12T07:04:06Z

src/main/java/HookKiller/server/board/controller/ArticleController.java

+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.springframework.http.ResponseEntity;
+import org.springframework.web.bind.annotation.*;


Suggested change

import org.springframework.web.bind.annotation.*;

import org.springframework.web.bind.annotation.DeleteMapping;

import org.springframework.web.bind.annotation.GetMapping;

import org.springframework.web.bind.annotation.PathVariable;

import org.springframework.web.bind.annotation.PostMapping;

import org.springframework.web.bind.annotation.RequestBody;

import org.springframework.web.bind.annotation.RequestMapping;

import org.springframework.web.bind.annotation.RestController;

donsonioc2010 · 2023-10-12T07:05:27Z

src/main/java/HookKiller/server/board/controller/ArticleController.java

+    BoardType language = BoardType.valueOf(request.getHeader("language"));
+    return articleService.getArticleList(boardId, language);


이게 낫지 않을까요?, "language"는 따로 상수화 시키는게 좋을 것 같네요.

Suggested change

BoardType language = BoardType.valueOf(request.getHeader("language"));

return articleService.getArticleList(boardId, language);

return articleService.getArticleList(boardId, BoardType.valueOf(request.getHeader("language")));

donsonioc2010 · 2023-10-12T07:06:52Z

src/main/java/HookKiller/server/board/controller/ArticleController.java

+    articleContentService.updateContent(
+            requestDto, articleService.updateArticle(articleId, requestDto)
+    );


여기는 깊게 생각해봤는데 두개를 한개의 메소드에서 작업하고 Transactional 처리를 해야 할 것 같습니다.

번역에 실패하면 롤백해야 하기 떄문입니다.

donsonioc2010 · 2023-10-12T07:18:06Z

src/main/java/HookKiller/server/board/repository/ArticleRepository.java

+
+public interface ArticleRepository extends JpaRepository<Article, Long> {
+
+  public List<Article> findAllByBoard(Board board);


public이라면 접근제어자가 굳이 필요하지 않습니다.

donsonioc2010 · 2023-10-12T07:19:38Z

src/main/java/HookKiller/server/board/repository/ArticleRepository.java

+
+  public List<Article> findAllByBoard(Board board);
+
+  List<Article> findAllByBoardAndStatus(Board board, String status);


해당 메소드가 실행이 되는지 확인하시기 바랍니다.

또한 파라미터도 정상적으로 기입하였는지 확인바랍니다.

donsonioc2010 · 2023-10-12T07:20:45Z

src/main/java/HookKiller/server/board/service/ArticleContentService.java

+    List<LanguageType> targetLanguageList = Arrays.stream(LanguageType.values())
+            .filter(languageType -> !languageType.equals(requestDto.getOrgArticleLanguage()))
+            .toList();
+
+    List<ArticleContent> articleContentList = new ArrayList<>(
+            targetLanguageList.stream().map(
+                    languageType -> ArticleContent.builder()
+                            .article(article)
+                            .language(languageType)
+                            .title(getTranslatePapagoTextArticleContent(requestDto.getOrgArticleLanguage().getLanguageCode(), languageType.getLanguageCode(), requestDto.getTitle()))
+                            .content(getTranslatePapagoHTMLArticleContent(requestDto.getOrgArticleLanguage().getLanguageCode(), languageType.getLanguageCode(), requestDto.getContent()))
+                            .build()
+            ).toList()
+    );
+    articleContentList.add(
+            ArticleContent.builder()
+                    .article(article)
+                    .language(requestDto.getOrgArticleLanguage())
+                    .title(requestDto.getTitle())
+                    .content(requestDto.getContent())
+                    .build()
+    );
+    articleContentRepository.saveAll(articleContentList);


ArticleController에서 했던 말처럼 articleService에서 기록했던 것처럼 한개의 메소드에서 처리가 필요할 것 같습니다.

donsonioc2010 · 2023-10-12T07:20:52Z

src/main/java/HookKiller/server/board/service/ArticleContentService.java

+  public void updateContent(PostArticleRequestDto requestDto, Article article) {
+    // 게시물의 모든 내용을 찾습니다.
+    List<ArticleContent> existingContents = articleContentRepository.findAllByArticle(article);
+
+    // 원본 언어의 내용을 업데이트합니다.
+    existingContents.stream()
+            .filter(content -> content.getLanguage().equals(requestDto.getOrgArticleLanguage()))
+            .forEach(content -> {
+              content.articleUpdate(requestDto.getTitle(), requestDto.getContent());
+            });
+
+    // 다른 언어로 번역된 내용들을 업데이트합니다.
+    for (LanguageType languageType : LanguageType.values()) {
+      if (!languageType.equals(requestDto.getOrgArticleLanguage())) {
+        existingContents.stream()
+                .filter(content -> content.getLanguage().equals(languageType))
+                .forEach(content -> {
+                  content.articleUpdate(getTranslatePapagoTextArticleContent(requestDto.getOrgArticleLanguage().getLanguageCode(), languageType.getLanguageCode(), requestDto.getTitle()),
+                          getTranslatePapagoHTMLArticleContent(requestDto.getOrgArticleLanguage().getLanguageCode(), languageType.getLanguageCode(), requestDto.getContent()));
+                });
+      }
+    }
+
+    articleContentRepository.saveAll(existingContents);
+  }


ArticleController에서 했던 말처럼 articleService에서 기록했던 것처럼 한개의 메소드에서 처리가 필요할 것 같습니다.

donsonioc2010 · 2023-10-12T07:21:50Z

src/main/resources/application-local.yml

@@ -2,7 +2,7 @@
 hook:
  db:
    url: db-it7f7-kr.vpc-pub-cdb.ntruss.com
-    database: jw
+    database: js


진석 + 정훈 기능 join

…pleController로 분리

donsonioc2010

LGTM

bongsh0112

LGTM 고생하셨습니다

lljh1992 and others added 7 commits October 6, 2023 19:30

feat : 레포작업중

bf94604

.

feat : 게시판 기능 구현

705bfce

.

Feat : article 전체조회 기능구현

80c7587

Feat : article 조회 기능 구현

c2b9536

merge dev

641d9d7

board entity, repo 작업 완료

e12d183

Merge branch 'dev' into feat/10-board

3ea011f

lgsok00 added the enhancement New feature or request label Oct 10, 2023

lgsok00 requested review from donsonioc2010 and bongsh0112 October 10, 2023 01:46

lgsok00 self-assigned this Oct 10, 2023

build complate

a22cf17

bongsh0112 requested changes Oct 10, 2023

View reviewed changes

donsonioc2010 requested changes Oct 10, 2023

View reviewed changes

donsonioc2010 assigned lljh1992 Oct 10, 2023

lgsok00 added 6 commits October 10, 2023 21:35

이슈 수정

d1ec33d

feat : 게시물 등록 진행중, 임시 커밋

7dfd2ce

Merge branch 'dev' into feat/10-board

5317d86

게시글 등록, 조회, 삭제 구현

de9352f

papago api

56d8b69

게시판 CRUD 구현

f4f30c3

donsonioc2010 requested changes Oct 12, 2023

View reviewed changes

lgsok00 and others added 4 commits October 12, 2023 20:32

이슈 수정

b87863f

feat : 게시판 CRUD + papago 기능구현

fbc844a

진석 + 정훈 기능 join

fix : 편안

5df9c1a

refactor : Package Import * 제거 및 HealthController의 Papago기능 PapagoSam…

c9b4cb5

…pleController로 분리

donsonioc2010 self-requested a review October 13, 2023 00:27

donsonioc2010 approved these changes Oct 13, 2023

View reviewed changes

donsonioc2010 requested review from bongsh0112 and removed request for bongsh0112 October 13, 2023 00:30

bongsh0112 approved these changes Oct 13, 2023

View reviewed changes

bongsh0112 merged commit 031b0e5 into dev Oct 13, 2023
1 check passed

bongsh0112 deleted the feat/10-board branch October 13, 2023 00:41

donsonioc2010 mentioned this pull request Oct 15, 2023

[FEATURE] 게시글 기능 구현 #10

Closed


		private final ArticleService articleService;

		@GetMapping("{/boardId}")

		package HookKiller.server.board.entity;


		import jakarta.persistence.*;



		import HookKiller.server.common.AbstractTimeStamp;
		import jakarta.persistence.*;

-import org.springframework.web.bind.annotation.*;
+import org.springframework.web.bind.annotation.DeleteMapping;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.PathVariable;
+import org.springframework.web.bind.annotation.PostMapping;
+import org.springframework.web.bind.annotation.RequestBody;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RestController;

		BoardType language = BoardType.valueOf(request.getHeader("language"));
		return articleService.getArticleList(boardId, language);


		public interface ArticleRepository extends JpaRepository<Article, Long> {

		public List<Article> findAllByBoard(Board board);


		public List<Article> findAllByBoard(Board board);

		List<Article> findAllByBoardAndStatus(Board board, String status);

Feat/10 board - 게시판 entity , repo 작성 #20

Feat/10 board - 게시판 entity , repo 작성 #20

Conversation

lgsok00 commented Oct 10, 2023

bongsh0112 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

donsonioc2010 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

donsonioc2010 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

donsonioc2010 left a comment

Choose a reason for hiding this comment

bongsh0112 left a comment

Choose a reason for hiding this comment