From be7f1e14a2ecae57a423643f2b132933b4e81c06 Mon Sep 17 00:00:00 2001 From: Phil Leggetter Date: Wed, 8 May 2024 13:29:23 +0100 Subject: [PATCH 1/3] chore: experiment with docker action --- .github/workflows/test.yml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 4e6fb0e..1bfbb48 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -35,12 +35,17 @@ jobs: uses: actions/checkout@v4 with: fetch-depth: 0 + - name: Docker Login - env: - DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }} - DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }} - run: | - echo "${DOCKER_PASSWORD}" | docker login --username "${DOCKER_USERNAME}" --password-stdin + uses: docker/login-action@v3 + with: + username: ${{ secrets.DOCKER_USERNAME }} + password: ${{ secrets.DOCKER_PASSWORD }} + # env: + # DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }} + # DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }} + # run: | + # echo "${DOCKER_PASSWORD}" | docker login --username "${DOCKER_USERNAME}" --password-stdin - name: Set up Docker QEMU uses: docker/setup-qemu-action@v3 - name: Set up Docker Buildx From 0d8576c4c726f9f6e1e657413be1161fa3a8aa35 Mon Sep 17 00:00:00 2001 From: Phil Leggetter Date: Wed, 8 May 2024 13:31:36 +0100 Subject: [PATCH 2/3] chore(CI): remove commented code --- .github/workflows/test.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1bfbb48..b0a8b07 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -35,17 +35,11 @@ jobs: uses: actions/checkout@v4 with: fetch-depth: 0 - - name: Docker Login uses: docker/login-action@v3 with: username: ${{ secrets.DOCKER_USERNAME }} password: ${{ secrets.DOCKER_PASSWORD }} - # env: - # DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }} - # DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }} - # run: | - # echo "${DOCKER_PASSWORD}" | docker login --username "${DOCKER_USERNAME}" --password-stdin - name: Set up Docker QEMU uses: docker/setup-qemu-action@v3 - name: Set up Docker Buildx From 8d869eb15540e90213427115f725aaa4cd54f10c Mon Sep 17 00:00:00 2001 From: Phil Leggetter Date: Wed, 8 May 2024 13:32:15 +0100 Subject: [PATCH 3/3] chore(CI): update release to use docker action --- .github/workflows/release.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 4d2a315..a2f39bc 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -36,11 +36,10 @@ jobs: with: fetch-depth: 0 - name: Docker Login - env: - DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }} - DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }} - run: | - echo "${DOCKER_PASSWORD}" | docker login --username "${DOCKER_USERNAME}" --password-stdin + uses: docker/login-action@v3 + with: + username: ${{ secrets.DOCKER_USERNAME }} + password: ${{ secrets.DOCKER_PASSWORD }} - name: Set up Docker QEMU uses: docker/setup-qemu-action@v3 - name: Set up Docker Buildx