Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: sdk_max_attempts naming #113

Open
leggetter opened this issue Oct 11, 2024 · 1 comment
Open

Discussion: sdk_max_attempts naming #113

leggetter opened this issue Oct 11, 2024 · 1 comment

Comments

@leggetter
Copy link
Collaborator

@alexluong I'm wondering if we should rename sdk_max_attempts to max_retry_attempts?

  1. Why do we need to leak that this is a config option passed to the SDK?
  2. We're missing that this is config about how many "retries" to attempt. So, how about adding retry to the name?

The release has gone out as a beta, so if we agree on this change, I'd suggest we rename it as a breaking change in the v0.5.0 full release.

@leggetter leggetter changed the title Discussion: sdk_max_attempts naming Discussion: sdk_max_attempts naming Oct 11, 2024
@alexluong
Copy link
Collaborator

I think whichever name makes sense. I was trying to be consistent with the SDK. If you don't think it's helpful and rather treat TF as its own thing then we can certainly go with that.

The original idea was that if in the future there are other SDK options that we want to support, then we have the sdk_... prefix as a naming convention. But I also get where you're coming from as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants