Skip to content
This repository has been archived by the owner on Feb 3, 2022. It is now read-only.

Why the id attribute in the grid item is required to be a Number? #86

Open
rafaelmaiolla opened this issue Mar 29, 2016 · 2 comments
Open

Comments

@rafaelmaiolla
Copy link

The following line: https://github.com/hootsuite/grid/blob/master/src/jquery.gridList.js#L201 transform the id to a number. Is there a reason for the id to be a number?

@ovidiu-chereches-hs
Copy link

Is there a reason for the id to be a number?

Can't think of one, probably just a legacy decision. If I'm not mistaken, id is just a generic assumption the lib has about your items, but it doesn't actually use it anywhere. @NiGhTTraX correct me if I'm wrong.

@andrei-picus-hs
Copy link
Contributor

@ovidiu-chereches-hs seems that way. At first I thought it was used inside the jQuery plugin to get the list of changed items, but it's using $element for that. Someone should remove it and see if anything breaks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants