fixed incorrect return-type in data-profiler

hostnet · Sep 23, 2019 · ff3feb8 · ff3feb8
1 parent 2aebd38
commit ff3feb8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/Component/Profiler/WebpackDataCollector.php b/src/Component/Profiler/WebpackDataCollector.php
@@ -48,9 +48,9 @@ public function reset()
     /**
      * @param  string $id
      * @param  mixed  $default
-     * @return string
+     * @return null|string
      */
-    public function get($id, $default = false): string
+    public function get($id, $default = false): ?string
     {
         return $this->profiler->get($id, $default);
     }

diff --git a/test/Component/Profiler/WebpackDataCollectorTest.php b/test/Component/Profiler/WebpackDataCollectorTest.php
@@ -20,13 +20,16 @@ public function testProfiler(): void
     {
         $profiler  = new Profiler();
         $collector = new WebpackDataCollector($profiler);
-        $profiler->set('foobar', 'hoi');
         $collector->collect(
             $this->getMockBuilder(Request::class)->getMock(),
             $this->getMockBuilder(Response::class)->getMock()
         );
 
-        self::assertEquals('hoi', $collector->get('foobar'));
         self::assertEquals('webpack', $collector->getName());
+        self::assertNull($collector->get('foobar'));
+
+        $profiler->set('foobar', 'hoi');
+
+        self::assertEquals('hoi', $collector->get('foobar'));
     }
 }