-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency in taskID on project details page and mapper's page #1982
Comments
@spwoodcock in the activities panel, we need to replace |
In the submission table for the react frontend? Updating the activities panel on the mapper frontend is all needed to as you say - just updating the number is fine I think |
No. In the activities section in the mapper frontend, we show the task id in the UI. To ensure consistency over the UI we should also display the task index in the activities section. Currently, only task id is being returned from electric SQL since it's querying from the |
Oh sorry, I get you! I don't think we should display the task id to the user. Only the index 👍 If we could remove the id reference entirely it would be great, but I think we need it for calling the API and adding new events |
Yeah for the visible part of UI, we should use index, but we need id for API calls. |
Oh you mean we might need to add task index to the task events table? I'm reluctant to do that, as its a computed field anyway, rather than a user input of real value. I understand the issue now, as the task index is typically calculated on the backend for the tasks API response, but we are using electric. Based on the response from electric, could we not find the max and min task ids, set to an internal value in the store, then calculate the range (max-min) to set the task index values based on the task ids? Or something similar to this |
Then I'll make a list of objects mapping the task id with its index the {id: index}[]. Both id and index are returned in the /project/:id/minimal API. Then access the index where needed. |
Describe the bug
The taskID on project details page on management frontend is different than the taskID of same task on mapper view. On project details page, the taskId start from 1 whereas the number is large on mapper's page
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The taskId should be consistent on each page
Screenshots


Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: