-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapper frontend basemap management pt2 #1925
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
New feature or request
frontend
Related to frontend code
backend
Related to backend code
migration
Contains a DB migration
labels
Nov 28, 2024
NSUWAL123
approved these changes
Nov 28, 2024
Sujanadh
reviewed
Nov 29, 2024
spwoodcock
force-pushed
the
feat/mapper-pmtiles-pt2
branch
from
November 30, 2024 10:03
4b241d1
to
8a4d26f
Compare
I also updated the React frontend, to remove loading the OPFS PMTiles layer, instead loading it from the online URL (we expect the management frontend is used when the user has good internet) π Had to tweak the base layer selector slightly too, allowing for reactive selection of the current baselayer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
Related to backend code
enhancement
New feature or request
frontend
Related to frontend code
migration
Contains a DB migration
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Continuation from #1922
Fixes #1552
Describe this PR
url
field in the db.{projectId}/all.pmtiles
to{projectId}/basemap.pmtiles
in the OPFS storage.Screenshots
Alternative Approaches Considered
Review Guide
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?