Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix basemapper.py threading, add wrapper func, add PMTile support #202

Merged
merged 9 commits into from
Oct 10, 2023
Merged

Fix basemapper.py threading, add wrapper func, add PMTile support #202

merged 9 commits into from
Oct 10, 2023

Conversation

spwoodcock
Copy link
Member

@spwoodcock spwoodcock commented Oct 10, 2023 •
edited
Loading

#201 is still an enimga 😅
This PR fixes a small bug with dlthread, not passing the xy param.

  1. Fix basemapper dlthread✅
  2. Wrap basemapper.py functionality in a helper create_basemap_file() function (handling download and mbtile generation together - i.e. the content that was once in main())✅
  3. Add PMTile support if the user specifies outfile="xxx.pmtile" ✅

This PR also allows for more flexible specification of sqlite format: .sqlite, .sqlitedb, .sqlite3 etc (anything with sqlite in the extension)

@spwoodcock spwoodcock temporarily deployed to test October 10, 2023 18:17 — with GitHub Actions Inactive
@spwoodcock spwoodcock self-assigned this Oct 10, 2023
@github-actions github-actions bot added devops docs Improvements or additions to documentation labels Oct 10, 2023
@spwoodcock spwoodcock added bug Something isn't working enhancement New feature or request Priority: Must have High Priority and removed docs Improvements or additions to documentation devops labels Oct 10, 2023
@pre-commit-ci pre-commit-ci bot temporarily deployed to test October 10, 2023 18:18 Inactive
@github-actions github-actions bot added devops docs Improvements or additions to documentation labels Oct 10, 2023
@spwoodcock spwoodcock added dependency Includes a dependency change and removed devops Priority: Must have High Priority labels Oct 10, 2023
@spwoodcock spwoodcock temporarily deployed to test October 10, 2023 21:56 — with GitHub Actions Inactive
@spwoodcock spwoodcock marked this pull request as ready for review October 10, 2023 21:58
@spwoodcock spwoodcock merged commit 3d575ae into main Oct 10, 2023
2 checks passed
@spwoodcock spwoodcock deleted the fix/basemapper branch October 10, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spwoodcock spwoodcock

Labels
bug Something isn't working dependency Includes a dependency change devops docs Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@spwoodcock