Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ATP rule execution logic to enhance efficiency #38

Open
ravilodhi opened this issue Dec 13, 2024 · 0 comments
Open

Enhance ATP rule execution logic to enhance efficiency #38

ravilodhi opened this issue Dec 13, 2024 · 0 comments
Assignees

Comments

@ravilodhi
Copy link
Contributor

Currently, every time the ATP rule group executes, it generates a complete CSV containing all eligible products. It does not take into account whether a product has been modified since the last execution or whether the rules have changed since the last run. This results in the CSV being generated with the same data repeatedly, even when there are no changes.

To address this, consider the following approach:

If the rule group has been modified (e.g., new rules are added, existing rules are updated, or archived) since the last successful execution, process all products.
If the rule group has not been modified, only fetch products that have been updated since the last successful rule group execution. Use the updatedDatetime from the Product Solr document for this purpose.

@ravilodhi ravilodhi self-assigned this Dec 13, 2024
ravilodhi added a commit that referenced this issue Dec 13, 2024
…rule group is modified since the last run; otherwise, process only products updated since the last successful run (#38).
ravilodhi added a commit that referenced this issue Dec 17, 2024
…whether all products need to be scaned while running rule group (#38).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant