Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize code to improving readability and consistancy #164

Open
1 of 2 tasks
ymaheshwari1 opened this issue Jan 31, 2023 · 2 comments
Open
1 of 2 tasks

Optimize code to improving readability and consistancy #164

ymaheshwari1 opened this issue Jan 31, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@ymaheshwari1
Copy link
Contributor

ymaheshwari1 commented Jan 31, 2023

Current behavior

  1. When uploading a file we are storing the file content's in a variable which is an array of object, and when accessing that variable we are always accessing 0th index of it to use the file's content which will be difficult to handle. So when storing the file content in the variable we can save the 0th index so everytime when accessing it, we don't need to explicitly define the index.

  2. In areAllFieldsSelected method we are using every method to check for un-selected values when mapping, but we can simply use some method and revert its logic.

Expected behavior

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information

@ymaheshwari1 ymaheshwari1 added the bug Something isn't working label Jan 31, 2023
@ymaheshwari1 ymaheshwari1 changed the title Optimize code to improve performance Optimize code to improving readability and consistancy Jan 31, 2023
@adityasharma7 adityasharma7 moved this to 📋 Backlog in Digital Experience Platform Feb 6, 2023
@HarshitaSultanpure
Copy link

would you please assign this to me

@alsoK2maan
Copy link
Contributor

Sure @HarshitaSultanpure go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants