Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix matching of product not working on the internalName #606

Closed
2 tasks
amansinghbais opened this issue Jan 15, 2025 · 1 comment
Closed
2 tasks

Fix matching of product not working on the internalName #606

amansinghbais opened this issue Jan 15, 2025 · 1 comment
Assignees
@Adameddy26
Labels
bug Something isn't working release-v2.6.4

Comments

@amansinghbais
Copy link
Contributor

Current behavior

Currently the matching of products only works on the identifiers in the goodIdentifications.

Expected behavior

Instead it should also work on the hardcoded identifiers which are not present in the good identifications.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information
@amansinghbais amansinghbais added the bug Something isn't working label Jan 15, 2025
@amansinghbais amansinghbais self-assigned this Jan 15, 2025
amansinghbais added a commit to amansinghbais/inventory-count that referenced this issue Jan 15, 2025
@amansinghbais
Improved: support for matching of products for the identifiers not in…
6dcf957 
… goodIdentifications (hotwax#606)
@amansinghbais amansinghbais mentioned this issue Jan 15, 2025
Merged
1 task
@amansinghbais amansinghbais moved this from 📋 Backlog to 👀 In review in Digital Experience Platform Jan 15, 2025
amansinghbais added a commit to amansinghbais/inventory-count that referenced this issue Jan 15, 2025
@amansinghbais
Improved: added check to handle undefined product identification whil…
4b780f7 
…e parsing (hotwax#606)
amansinghbais added a commit to amansinghbais/inventory-count that referenced this issue Jan 15, 2025
@amansinghbais
Fixed: default value for the product identifications (hotwax#606)
e4e5151
amansinghbais added a commit to amansinghbais/inventory-count that referenced this issue Jan 15, 2025
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/inventory-count into h…
7f3d682 
…otwax#606
amansinghbais added a commit to amansinghbais/inventory-count that referenced this issue Jan 15, 2025
@amansinghbais
Improved: refetching the product store setting on the count details p…
17e1927 
…age (hotwax#606)
amansinghbais added a commit to amansinghbais/inventory-count that referenced this issue Jan 15, 2025
@amansinghbais
Improved: trimming the queryString on scanning (hotwax#606)
1e7f995
ravilodhi added a commit that referenced this issue Jan 15, 2025
@ravilodhi
Merge pull request #607 from amansinghbais/#606
84aa3c4 
Improved: support for matching of products for the identifiers not in goodIdentifications (#606)
amansinghbais added a commit to amansinghbais/inventory-count that referenced this issue Jan 15, 2025
@amansinghbais
Improved: added permission check for fetching product stores while lo…
c243c3e 
…gin and passing facility store as param while fetching settings (hotwax#606)
@amansinghbais amansinghbais mentioned this issue Jan 15, 2025
Merged
1 task
amansinghbais added a commit to amansinghbais/inventory-count that referenced this issue Jan 15, 2025
@amansinghbais
Fixed: re-initializing the observer when changing the segment (hotwax…
1dad5b4 
…#606)
amansinghbais added a commit to amansinghbais/inventory-count that referenced this issue Jan 15, 2025
@amansinghbais
Improved: added a setTimeOut for initializing the observer on segment…
24ec014 
… change (hotwax#606)
ymaheshwari1 added a commit that referenced this issue Jan 15, 2025
@ymaheshwari1
Merge pull request #611 from amansinghbais/#606
0f2b884 
Improved: added permission check for fetching product stores while login and passing facility store as param while fetching settings (#606)
amansinghbais added a commit to amansinghbais/inventory-count that referenced this issue Jan 15, 2025
@amansinghbais
Improved: used nextTick instead of timeOut in segment change for obse…
d48a440 
…rver (hotwax#606)
@amansinghbais amansinghbais mentioned this issue Jan 15, 2025
Merged
1 task
ymaheshwari1 added a commit that referenced this issue Jan 15, 2025
@ymaheshwari1
Merge pull request #612 from amansinghbais/#606
86f9a13 
Improved: used nextTick instead of timeOut in segment change for observer (#606)
@amansinghbais amansinghbais moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jan 15, 2025
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to ⚒️ In QA in Digital Experience Platform Jan 22, 2025
@dt2patel
Copy link
Contributor

dt2patel commented Feb 4, 2025

fixed in production. Closing issue

@dt2patel dt2patel closed this as completed Feb 4, 2025
@github-project-automation github-project-automation bot moved this from ⚒️ In QA to ✅ Done in Digital Experience Platform Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working release-v2.6.4
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dt2patel @amansinghbais @Adameddy26