From 1ebfa471d7c71d3b34ed4145707779e3ffe3e4a0 Mon Sep 17 00:00:00 2001 From: amansinghbais Date: Fri, 29 Nov 2024 11:04:06 +0530 Subject: [PATCH] Improved: updated the variable name for clearing current job for better understanding (#720) --- src/views/Brokering.vue | 4 ++-- src/views/Fulfillment.vue | 4 ++-- src/views/InitialLoad.vue | 4 ++-- src/views/Inventory.vue | 4 ++-- src/views/Miscellaneous.vue | 4 ++-- src/views/Orders.vue | 4 ++-- src/views/Pipeline.vue | 4 ++-- src/views/PreOrder.vue | 4 ++-- src/views/Product.vue | 4 ++-- src/views/Reports.vue | 4 ++-- 10 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/views/Brokering.vue b/src/views/Brokering.vue index 3380bda7..2b92075d 100644 --- a/src/views/Brokering.vue +++ b/src/views/Brokering.vue @@ -208,8 +208,8 @@ export default defineComponent({ this.getTemporalExpr(this.getJobStatus(this.jobEnums[enumId]))?.description : translate('Disabled') }, - async fetchJobs(JobDetailDismissRequired = false) { - if(JobDetailDismissRequired) { + async fetchJobs(isCurrentJobUpdateRequired = false) { + if(isCurrentJobUpdateRequired) { this.currentJob = ""; await this.store.dispatch('job/updateCurrentJob', { }); this.currentJobStatus = ""; diff --git a/src/views/Fulfillment.vue b/src/views/Fulfillment.vue index 03fdfe99..2e8a3c11 100644 --- a/src/views/Fulfillment.vue +++ b/src/views/Fulfillment.vue @@ -240,9 +240,9 @@ export default defineComponent({ this.store.dispatch('job/updateJob', job) } }, - async fetchJobs(JobDetailDismissRequired = false){ + async fetchJobs(isCurrentJobUpdateRequired = false){ this.isLoading = true; - if(JobDetailDismissRequired) { + if(isCurrentJobUpdateRequired) { this.currentJob = ""; await this.store.dispatch('job/updateCurrentJob', { }); this.currentJobStatus = ""; diff --git a/src/views/InitialLoad.vue b/src/views/InitialLoad.vue index 6d4c39a4..54bd72cc 100644 --- a/src/views/InitialLoad.vue +++ b/src/views/InitialLoad.vue @@ -207,8 +207,8 @@ export default defineComponent({ this.isJobDetailAnimationCompleted = true; } }, - async fetchJobs(JobDetailDismissRequired = false){ - if(JobDetailDismissRequired) { + async fetchJobs(isCurrentJobUpdateRequired = false){ + if(isCurrentJobUpdateRequired) { this.currentSelectedJobModal = ""; await this.store.dispatch('job/updateCurrentJob', { }); this.job = {}; diff --git a/src/views/Inventory.vue b/src/views/Inventory.vue index 7b2900fe..d7672409 100644 --- a/src/views/Inventory.vue +++ b/src/views/Inventory.vue @@ -178,8 +178,8 @@ export default defineComponent({ }); this.isLoading = false }, - async fetchData(JobDetailDismissRequired = false) { - if(JobDetailDismissRequired) { + async fetchData(isCurrentJobUpdateRequired = false) { + if(isCurrentJobUpdateRequired) { this.currentJob = ""; await this.store.dispatch('job/updateCurrentJob', { }); this.currentJobStatus = ""; diff --git a/src/views/Miscellaneous.vue b/src/views/Miscellaneous.vue index abc0d0f9..447ff4c1 100644 --- a/src/views/Miscellaneous.vue +++ b/src/views/Miscellaneous.vue @@ -150,8 +150,8 @@ export default defineComponent({ async getMiscellaneousJobs(viewSize = 100, viewIndex = 0) { await this.store.dispatch('job/fetchMiscellaneousJobs', {eComStoreId: this.getCurrentEComStore.productStoreId, viewSize, viewIndex}); }, - async updateProductStoreConfig(JobDetailDismissRequired = false) { - if(JobDetailDismissRequired) { + async updateProductStoreConfig(isCurrentJobUpdateRequired = false) { + if(isCurrentJobUpdateRequired) { this.currentJob = ""; await this.store.dispatch('job/updateCurrentJob', { }); this.currentJobStatus = ""; diff --git a/src/views/Orders.vue b/src/views/Orders.vue index ea47df05..38bbfca1 100644 --- a/src/views/Orders.vue +++ b/src/views/Orders.vue @@ -279,9 +279,9 @@ export default defineComponent({ this.getTemporalExpr(this.getJobStatus(this.jobEnums[enumId]))?.description : translate('Disabled') }, - async fetchJobs(JobDetailDismissRequired = false){ + async fetchJobs(isCurrentJobUpdateRequired = false){ this.isLoading = true; - if(JobDetailDismissRequired) { + if(isCurrentJobUpdateRequired) { this.currentJob = "" await this.store.dispatch('job/updateCurrentJob', { }); this.currentJobStatus = "" diff --git a/src/views/Pipeline.vue b/src/views/Pipeline.vue index 3f70b9c4..b1fdfe5c 100644 --- a/src/views/Pipeline.vue +++ b/src/views/Pipeline.vue @@ -647,8 +647,8 @@ export default defineComponent({ this.getPendingJobs(); } }, - async updateProductStoreConfig(JobDetailDismissRequired = false) { - if(JobDetailDismissRequired) { + async updateProductStoreConfig(isCurrentJobUpdateRequired = false) { + if(isCurrentJobUpdateRequired) { this.jobsLoading = true; await this.store.dispatch('job/updateCurrentJob', { job: {} }); this.currentJobStatus = "" diff --git a/src/views/PreOrder.vue b/src/views/PreOrder.vue index cf392728..7a13c4e6 100644 --- a/src/views/PreOrder.vue +++ b/src/views/PreOrder.vue @@ -363,8 +363,8 @@ export default defineComponent({ } }); }, - async fetchInitialData(JobDetailDismissRequired = false) { - if(JobDetailDismissRequired) { + async fetchInitialData(isCurrentJobUpdateRequired = false) { + if(isCurrentJobUpdateRequired) { this.currentJob = ""; await this.store.dispatch('job/updateCurrentJob', { }); this.currentJobStatus = "" diff --git a/src/views/Product.vue b/src/views/Product.vue index e8b356c6..b4082df4 100644 --- a/src/views/Product.vue +++ b/src/views/Product.vue @@ -192,9 +192,9 @@ export default defineComponent({ this.getTemporalExpr(this.getJobStatus(this.jobEnums[enumId]))?.description : translate('Disabled') }, - async fetchJobs(JobDetailDismissRequired = false){ + async fetchJobs(isCurrentJobUpdateRequired = false){ this.isLoading = true; - if(JobDetailDismissRequired) { + if(isCurrentJobUpdateRequired) { this.currentJob = "" await this.store.dispatch('job/updateCurrentJob', { }); this.currentJobStatus = "" diff --git a/src/views/Reports.vue b/src/views/Reports.vue index 33c54381..71a6d243 100644 --- a/src/views/Reports.vue +++ b/src/views/Reports.vue @@ -138,8 +138,8 @@ export default defineComponent({ async getReportsJobs(viewSize = 200, viewIndex = 0) { await this.store.dispatch('job/fetchReportsJobs', { eComStoreId: this.getCurrentEComStore.productStoreId, viewSize, viewIndex }); }, - async updateProductStoreConfig(JobDetailDismissRequired = false) { - if(JobDetailDismissRequired) { + async updateProductStoreConfig(isCurrentJobUpdateRequired = false) { + if(isCurrentJobUpdateRequired) { this.currentJob = ""; await this.store.dispatch('job/updateCurrentJob', { }); this.currentJobStatus = "";