-
Notifications
You must be signed in to change notification settings - Fork 33
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use ion-row instead of ion item for chips
@R-Sourabh let me know if this breaks anything
- Loading branch information
Showing
1 changed file
with
5 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,12 +41,12 @@ | |
<ion-item lines="none"> | ||
<ion-label>{{ translate("Sources") }}</ion-label> | ||
</ion-item> | ||
<ion-item v-for="section in jobSection" :key="section.id" lines="none"> | ||
<ion-row class="ion-padding" v-for="section in jobSection" :key="section.id" lines="none"> | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
dt2patel
Author
Contributor
|
||
<ion-chip outline @click="redirectToDoc(section)"> | ||
<ion-label>{{ section.title }}</ion-label> | ||
<ion-icon :icon="openOutline" /> | ||
</ion-chip> | ||
</ion-item> | ||
</ion-row> | ||
</ion-list> | ||
|
||
<ion-item> | ||
|
@@ -60,7 +60,7 @@ | |
</template> | ||
|
||
<script lang="ts"> | ||
import { IonButton, IonButtons, IonChip, IonContent, IonHeader, IonIcon, IonItem, IonLabel, IonList, IonSpinner, IonTitle, IonToolbar, modalController } from "@ionic/vue"; | ||
import { IonButton, IonButtons, IonChip, IonContent, IonHeader, IonIcon, IonItem, IonLabel, IonList,, IonRow, IonSpinner, IonTitle, IonToolbar, modalController } from "@ionic/vue"; | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. |
||
import { closeOutline, openOutline } from 'ionicons/icons' | ||
import { translate } from '@hotwax/dxp-components'; | ||
import { defineComponent } from "vue"; | ||
|
@@ -80,6 +80,7 @@ export default defineComponent({ | |
IonItem, | ||
IonLabel, | ||
IonList, | ||
IonRow, | ||
IonSpinner, | ||
IonTitle, | ||
IonToolbar | ||
|
@@ -167,4 +168,4 @@ export default defineComponent({ | |
}; | ||
} | ||
}) | ||
</script> | ||
</script> |
I think we should use 'ion-padding-start' instead of 'ion-padding'.
Additionally, we can remove the lines property from the ion-row.