Skip to content

Commit

Permalink
Use ion-row instead of ion item for chips
Browse files Browse the repository at this point in the history
@R-Sourabh  let me know if this breaks anything
  • Loading branch information
dt2patel authored Nov 28, 2024
1 parent d889a34 commit f5e624f
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/components/LearnMoreModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@
<ion-item lines="none">
<ion-label>{{ translate("Sources") }}</ion-label>
</ion-item>
<ion-item v-for="section in jobSection" :key="section.id" lines="none">
<ion-row class="ion-padding" v-for="section in jobSection" :key="section.id" lines="none">

This comment has been minimized.

Copy link
@R-Sourabh

R-Sourabh Nov 28, 2024

Contributor

I think we should use 'ion-padding-start' instead of 'ion-padding'.
Additionally, we can remove the lines property from the ion-row.

This comment has been minimized.

Copy link
@dt2patel

dt2patel Nov 28, 2024

Author Contributor

We'd want padding to apply to all sides since chips can wrap. Agreed that lines should be removed

<ion-chip outline @click="redirectToDoc(section)">
<ion-label>{{ section.title }}</ion-label>
<ion-icon :icon="openOutline" />
</ion-chip>
</ion-item>
</ion-row>
</ion-list>

<ion-item>
Expand All @@ -60,7 +60,7 @@
</template>

<script lang="ts">
import { IonButton, IonButtons, IonChip, IonContent, IonHeader, IonIcon, IonItem, IonLabel, IonList, IonSpinner, IonTitle, IonToolbar, modalController } from "@ionic/vue";
import { IonButton, IonButtons, IonChip, IonContent, IonHeader, IonIcon, IonItem, IonLabel, IonList,, IonRow, IonSpinner, IonTitle, IonToolbar, modalController } from "@ionic/vue";

This comment has been minimized.

Copy link
@R-Sourabh

R-Sourabh Nov 28, 2024

Contributor

Added one extra comma here.

This comment has been minimized.

Copy link
@dt2patel

dt2patel Nov 28, 2024

Author Contributor

fixed in next commit

import { closeOutline, openOutline } from 'ionicons/icons'
import { translate } from '@hotwax/dxp-components';
import { defineComponent } from "vue";
Expand All @@ -80,6 +80,7 @@ export default defineComponent({
IonItem,
IonLabel,
IonList,
IonRow,
IonSpinner,
IonTitle,
IonToolbar
Expand Down Expand Up @@ -167,4 +168,4 @@ export default defineComponent({
};
}
})
</script>
</script>

0 comments on commit f5e624f

Please sign in to comment.