Implemented: new UI for brokering page (#620) #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Oct 26, 2023
ymaheshwari1
requested changes
Oct 26, 2023
dt2patel
reviewed
Oct 26, 2023
src/views/Brokering.vue
Outdated
| </ion-item-divider> | ||
| </ion-card> | ||
|
|
||
| <ion-card :button="isDesktop" v-for="batch in orderBatchJobs" :key="batch?.id" detail v-show="batch?.status === 'SERVICE_PENDING'" @click="hasPermission(Actions.APP_JOB_UPDATE) && viewJobConfiguration({ id: batch.enumId, job: batch })"> |
There was a problem hiding this comment.
I think we should add a data attribute or class based on selected card. Maybe this can be done using a hidden radio button group. What do you think @ymaheshwari1
There was a problem hiding this comment.
Can check on displaying selected card using ion-radio-group.
ymaheshwari1
requested changes
Oct 26, 2023
ymaheshwari1
requested changes
Oct 30, 2023
ymaheshwari1
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #620
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Before
After
Contribution and Currently Important Rules Acceptance