Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Two Additional fields to Fulfillment Fact Entity #13

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

puru-khedre
Copy link
Collaborator

@puru-khedre puru-khedre commented Dec 24, 2024

Part of the Issue #12

Requirements

These two newly defined fields are required in the SM-specific report Sales by Item Level

@dt2patel
Copy link
Contributor

What data is expected in fulfilled by field? Where will we get it?

@puru-khedre
Copy link
Collaborator Author

puru-khedre commented Dec 24, 2024

What data is expected in fulfilled by field? Where will we get it?

It's the User login ID that fulfilled the Item, It will be available in the OrderStatus Entity which is already being used

@dt2patel
Copy link
Contributor

That is usually a facility login. Not the actual person that fulfilled the order. So how is that beneficial? We already have the facility on the order item

@puru-khedre
Copy link
Collaborator Author

I have not asked about its requirements. It is included in the sales report, so I just added it.

@puru-khedre
Copy link
Collaborator Author

puru-khedre commented Dec 24, 2024

@dt2patel sir, FulfilledBy field helps to track the manual completions.

@dt2patel
Copy link
Contributor

Makes sense.

@dt2patel dt2patel merged commit 885c5b1 into main Dec 24, 2024
@puru-khedre puru-khedre deleted the add-fields-to-fulfillment-fact branch December 24, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants