Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change obeserver not called if controller name contains uppercase characters #680

Open
RBastianini opened this issue May 12, 2023 · 2 comments · May be fixed by #697
Open

Change obeserver not called if controller name contains uppercase characters #680

RBastianini opened this issue May 12, 2023 · 2 comments · May be fixed by #697

Comments

@RBastianini
Copy link

I have encountered this behaviour that I believe to be a bug, where if a controller name contains an uppercase letter, value change callbacks are never fired.

Everything behaves as expected after converting the controller name to lowercase.

Please see this codepen for a demonstration: if you click the button, the text on the page does not change, however, if you rename the controller from Test to test (there are 4 occurrences in the html and 1 occurrence in the javascript) the text on the page changes after clicking the button. Tested on Firefox and Chrome.
@marcoroth
Copy link
Member

Hey @RBastianini, thanks for opening this issue!

While it's not recommended to use uppercase characters in controller names I think it would still make sense to fix this for consistency reasons. We recently also adjust this for action params, see #571.

Are you interested in giving this a shot?

@RBastianini RBastianini linked a pull request Jun 26, 2023 that will close this issue
Open
@RBastianini
Copy link
Author

I tried my hand at this. Apologies but I don't really speak *script too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed value change observers not firing RBastianini/stimulus
2 participants
@RBastianini @marcoroth