Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns don't apply as expected in pipe mode #63

Open
Altreus opened this issue Aug 3, 2016 · 2 comments
Open

Patterns don't apply as expected in pipe mode #63

Altreus opened this issue Aug 3, 2016 · 2 comments

Comments

@Altreus
Copy link

Altreus commented Aug 3, 2016

The following pattern successfully matches real files, but not pipes.

[CSSUnminify]
select = *.css

Produces:

$ tidyall path/to/existing/file.css
$ tidyall -p anything.css
test
^Dtest
No plugins apply for 'anything.css'

(I've inserted a ^D where I literally pressed ^D)

However, it works fine with an extended zglob, thus

[CSSUnminify]
select = **/*.css

$ tidyall -p anything.css
test
^Dtest

The difference is there's no warning (it is irrelevant whether the input file is valid according to the plugin).

@autarch
Copy link
Member

autarch commented Aug 3, 2016

I think the issue is probably that anything.css ends up getting turned into something like ./anything.css internally.

I wonder if this would be better as a doc fix that encourages the use of zglob patterns everywhere, since they're far more likely to do what you want anyway.

@autarch
Copy link
Member

autarch commented Aug 3, 2016

Hmm, or maybe that's not it. Anyway, if you could write a test case that'd be helpful. I'll try to investigate this when I have tuits, but those are in short supply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants