Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow sms mfa to be toggled on and off #637

Merged
merged 2 commits into from
Aug 15, 2023
Merged

fix: allow sms mfa to be toggled on and off #637

merged 2 commits into from
Aug 15, 2023

Conversation

ludtkemorgan
Copy link
Collaborator

@ludtkemorgan ludtkemorgan commented Aug 14, 2023

Pull Request Template

Issue Overview

This PR addresses #issue

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Due to a change in Twilio, our SMS messages are failing about 50% of the time. We are working to get this resolved, but it could take a few weeks. In the meantime we plan on turning off the option of using SMS as the 2fa method.

It will look like this
image

How Can This Be Tested/Reviewed?

in the .env file in partners add the following which will toggle the sms functionality off.
SHOW_SMS_MFA=FALSE

You will also need to have an account that has MFA enabled. The easiest way to do that is reseed and create a new account on the partner site. That new account should have MFA enabled by default

It is also recommended to test it with the above set to TRUE or not set at all

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit b343de1
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/64dab50dc9a59700086d68e0
😎 Deploy Preview https://deploy-preview-637--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ludtkemorgan looks good, could you also add this to the .env template so we can remember we have this in the future

@ludtkemorgan
Copy link
Collaborator Author

@YazeedLoonat This has been added!

@ludtkemorgan ludtkemorgan merged commit 409e569 into main Aug 15, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants