fix: allow sms mfa to be toggled on and off #637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Issue Overview
This PR addresses #issue
Description
Due to a change in Twilio, our SMS messages are failing about 50% of the time. We are working to get this resolved, but it could take a few weeks. In the meantime we plan on turning off the option of using SMS as the 2fa method.
It will look like this
How Can This Be Tested/Reviewed?
in the
.env
file in partners add the following which will toggle the sms functionality off.SHOW_SMS_MFA=FALSE
You will also need to have an account that has MFA enabled. The easiest way to do that is reseed and create a new account on the partner site. That new account should have MFA enabled by default
It is also recommended to test it with the above set to
TRUE
or not set at allChecklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.