18691: Add Reaction to replace CasesWithDetails as react return type, Major

[jackx111]

• Rename CasesWithDetails to Reaction
• Added the ability to instantiate the class with more than just a dataframe.
• Extended the types allowed for the dispatch method add_reaction to list of dicts and other classes of Reaction
• Removed support for add_reaction types of the old reaction type so now everything should be in this class. Also it had errors when trying to add_reaction other dicts due to the dispatch sending it to the wrong method

[jackx111]

Martins Comments on a previous PR

I think it's fair to say that the goal of the PR is to unify Reaction and ReactionSeries. So, I recommend that we explicitly do this. I see no reason (perhaps you do, let's discuss if so) why we can't just delete Reaction and ReactionSeries and then rename CasesWithDetails to Reaction.

Next, I don't think that CasesWithDetails (which is a concrete class) should be housed in the types.py module. However, once we do No. 1 above, the types.py module would only contain Distances, which is entirely unused, (in howso-engine-py, anyway), so perhaps we can just delete the whole thing? At this point, perhaps we just put the new Reaction (was CasesWithDetails) in a new module called simply: reaction.py.

If we can do these 2 things and fix up everything so that it all still passes tests, etc., it's a win!

[mkoistinen]

👍