Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS events connectionDidConnect, connectionDidDisconnect use to and from instead of call_to and call_from #44

Closed
fabriziomoscon opened this issue Oct 3, 2017 · 1 comment
Labels

Comments

@fabriziomoscon
Copy link
Collaborator

fabriziomoscon commented Oct 3, 2017

In version 3.2.0 the parameters for:

  • connectionDidConnect

  • connectionDidDisconnect
    are different between iOS and Android.

  • to is used instead of call_to

  • from is used instead of call_from

As a temporary fix you can migrate the parameters in your app:

if (Platform.OS === 'ios') {
  if (params.to) {
    params.call_to = params.to
    delete params.to
  }
  if (params.from) {
    params.call_from = params.from
    delete params.from
  }
}

Also on iOS the event connectionDidDisconnect uses the parameter error instead of err
As a temporary fix you can migrate the parameters in your app:

if (Platform.OS === 'ios') {
  if (params.error) {
    params.err = params.error
    delete params.error
  }
}
@fabriziomoscon
Copy link
Collaborator Author

on ios connectionDidConnect has no to and from parameters, this is different from the Android behaviour. See #62

fabriziomoscon added a commit that referenced this issue Dec 15, 2018
fixed connectionDidConnect, connectionDidDisconnect.
fixes #44 #62
fabriziomoscon added a commit that referenced this issue Dec 4, 2019
fixed connectionDidConnect, connectionDidDisconnect.
fixes #44 #62
fabriziomoscon added a commit that referenced this issue Dec 4, 2019
fixed connectionDidConnect, connectionDidDisconnect.
fixes #44 #62
fabriziomoscon added a commit that referenced this issue Dec 4, 2019
fixed connectionDidConnect, connectionDidDisconnect.
fixes #44 #62
fabriziomoscon added a commit that referenced this issue Jan 12, 2020
fixed connectionDidConnect, connectionDidDisconnect.
fixes #44 #62
fabriziomoscon added a commit that referenced this issue Jan 18, 2020
fixed connectionDidConnect, connectionDidDisconnect.
fixes #44 #62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant