Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI builds are no longer running #31

Open
ejd opened this issue Oct 1, 2021 · 3 comments
Open

CI builds are no longer running #31

ejd opened this issue Oct 1, 2021 · 3 comments

Comments

@ejd
Copy link
Collaborator

ejd commented Oct 1, 2021

Would you be interested in a PR that fixes CI for coilmq?

CI builds are not running anymore because this project (as far as I can tell) isn't yet configured to have CI run on travis-ci.com. travis-ci.org no longer does builds.

Unfortunately, the builds would fail even if they were running on the new travis-ci site. I forked coilmq to work on #29 and enabled travis-ci for the fork. My results look pretty much the same as when CI ran most recently against your repo for #28.

Pinning the fakeredis dependency to an earlier version may fix the problem with the python 2.7 build failures. Or, it may require listing a package multiple times in one of the requirements files and adding different environment markers to each. For example, fakeredis < X.Y.Z; python_version <= '2.7' and fakeredis >= X.Y.Z; python_version > '2.7'. If a quick fix like these can't be made to work, I could set you up with tox -- a little more involved but, IMHO, very worthwhile.

@hozn
Copy link
Owner

hozn commented Oct 1, 2021

@ejd , sure, I'd love it! Also, I'd probably get rid of python 2.x support if I were looking at this code again.

Do you want me to just make you a maintainer?

@ejd
Copy link
Collaborator Author

ejd commented Oct 1, 2021

I agree that it makes sense to drop Python 2.x support. I'm looking forward to helping out!

@hozn
Copy link
Owner

hozn commented Oct 1, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants