Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fine-tuning of the number of ranks per benchmark #82

Open
jeanbez opened this issue Mar 31, 2023 · 2 comments
Open

Allow fine-tuning of the number of ranks per benchmark #82

jeanbez opened this issue Mar 31, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jeanbez
Copy link
Member

jeanbez commented Mar 31, 2023

Today the number of ranks parameter is applied globally to all benchmarks in the JSON file. We should allow users to fine-tune it by providing a per-benchmark option to override this parameter. This will add flexibility and allow the JSON to be re-used between distinct experiment sizes.

@jeanbez jeanbez added the enhancement New feature or request label Mar 31, 2023
@jeanbez jeanbez added this to the v.1.4 milestone Mar 31, 2023
@jeanbez
Copy link
Member Author

jeanbez commented Mar 31, 2023

@sbyna what is your take on this? @xelasim reported some issues when running the metadata stress benchmark where one of its parameters depends on the total number of ranks.

@sbyna
Copy link
Member

sbyna commented Apr 4, 2023

Yes, capability to override the number of ranks per benchmark makes sense. It may even be necessary in some cases because of problem partitioning may be different for each benchmark. We can still keep the global # of ranks because if someone wants to run all the benchmarks at the same scale, they would have that option.

@jeanbez jeanbez modified the milestones: v.1.4, v.1.5 May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants