Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDE_DATA problems on AARCH64 #65

Open
SkyWorld117 opened this issue Mar 12, 2024 · 0 comments
Open

PDE_DATA problems on AARCH64 #65

SkyWorld117 opened this issue Mar 12, 2024 · 0 comments

Comments

@SkyWorld117
Copy link

In xpmem_pfn.c I noticed the following lines:

#if LINUX_VERSION_CODE < KERNEL_VERSION(5,17,0)
#define pde_data(indoe) PDE_DATA(inode)
#elif LINUX_VERSION_CODE < KERNEL_VERSION(3,10,0)
#define pde_data(inode) ((PDE(inode)->data))
#endif

First, I believe #define pde_data(indoe) PDE_DATA(inode) is a typo?

Second, isn't if more logical if checking version below 3.10.0 instead (as below)?

#if LINUX_VERSION_CODE < KERNEL_VERSION(3,10,0)
#define pde_data(inode) ((PDE(inode)->data))
#elif LINUX_VERSION_CODE < KERNEL_VERSION(5,17,0)
#define pde_data(inode) PDE_DATA(inode)
#endif

Third, I tried to compile it on Rocky Linux release 9.3 (Blue Onyx) on AARCH64 with kernel version 5.14.0-362.18.1.el9_3.0.1.aarch64, it is already using pde_data instead of PDE_DATA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant