Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Off-By-One errors in bounds for Circle and Group #80

Open
dasGoogle opened this issue Aug 3, 2022 · 0 comments
Open

Off-By-One errors in bounds for Circle and Group #80

dasGoogle opened this issue Aug 3, 2022 · 0 comments
Labels
defect Something isn't working

Comments

@dasGoogle
Copy link
Contributor

As a User, I expect the bounds of SVG elements to be calculated correctly in order to handle onClick events and other calculations correctly.

Currently, all bounds of circles and groups have an off by one error.

See these tests for an example:
SVGMorphTest>>testSVGCircleBounds

SVGMorphTest>>testSVGGroup

These tests are currently marked as expectedFailures. To test, them, you have to re-enable them.
@dasGoogle dasGoogle added the defect Something isn't working label Aug 3, 2022
@dasGoogle dasGoogle mentioned this issue Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dasGoogle