Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpdas doesn't use mpd's idle feature #26

Open
vifino opened this issue Dec 1, 2015 · 2 comments
Open

mpdas doesn't use mpd's idle feature #26

vifino opened this issue Dec 1, 2015 · 2 comments

Comments

@vifino
Copy link

vifino commented Dec 1, 2015

See http://git.musicpd.org/cgit/master/mpc.git/tree/src/idle.c for a small example of how to wait for a change to happen.

Probably not much effort, as far as I can tell, you'd only need to replace line 146 in main.cpp (usleep(500000);) with code handeling idle.

When the "player" event happens, update.

Since that'd mean mpdas gets changes instantly, it'd update a little bit faster and do less work while waiting.

@hrkfdn
Copy link
Owner

hrkfdn commented Dec 2, 2015

Hey, thanks for the report. This does seem pretty reasonable, but that loop is also responsible for processing cached scrobbles.

Maybe I can work out something smarter, although I believe that the gain of using mpd's idle is rather limited (unless your MPD does not run on the same host as mpdas). Nevertheless it is something that could be improved.

@UtkarshVerma
Copy link

UtkarshVerma commented Apr 27, 2020

Is this not going to be implemented soon? Would be awesome to see this getting implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants