From 219f676998cfdbf1299b9d99f0cd59eafd6889ff Mon Sep 17 00:00:00 2001
From: hrntsm <contact@hrntsm.com>
Date: Wed, 28 Feb 2024 10:47:10 +0900
Subject: [PATCH] Fix DateTime handling in Storage.cs and add hitl.db to
 OptunaTests.csproj

---
 Optuna/Storage/RDB/Storage.cs           |   3 ++-
 OptunaTests/OptunaTests.csproj          |   3 +++
 OptunaTests/Storage/RDB/StorageTests.cs |  10 ++++++++++
 OptunaTests/TestFile/hitl.db            | Bin 0 -> 122880 bytes
 4 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100644 OptunaTests/TestFile/hitl.db

diff --git a/Optuna/Storage/RDB/Storage.cs b/Optuna/Storage/RDB/Storage.cs
index 8981592a..5582b8e1 100644
--- a/Optuna/Storage/RDB/Storage.cs
+++ b/Optuna/Storage/RDB/Storage.cs
@@ -441,13 +441,14 @@ public Trial.Trial GetTrial(int trialId)
                     {
                         while (reader.Read())
                         {
+                            DateTime completeTime = reader.GetValue(3) is DBNull ? DateTime.MaxValue : reader.GetDateTime(3);
                             trial = new Trial.Trial
                             {
                                 TrialId = trialId,
                                 Number = reader.GetInt32(0),
                                 State = (TrialState)Enum.Parse(typeof(TrialState), reader.GetString(1), true),
                                 DatetimeStart = reader.GetDateTime(2),
-                                DatetimeComplete = reader.GetDateTime(3)
+                                DatetimeComplete = completeTime
                             };
                         }
                     }
diff --git a/OptunaTests/OptunaTests.csproj b/OptunaTests/OptunaTests.csproj
index 251df602..9d7d9678 100644
--- a/OptunaTests/OptunaTests.csproj
+++ b/OptunaTests/OptunaTests.csproj
@@ -27,6 +27,9 @@
     <None Update="TestFile\sqlite.db">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
+    <None Update="TestFile\hitl.db">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </None>
   </ItemGroup>
 
 </Project>
diff --git a/OptunaTests/Storage/RDB/StorageTests.cs b/OptunaTests/Storage/RDB/StorageTests.cs
index 4e7bf5f2..c6c21a46 100644
--- a/OptunaTests/Storage/RDB/StorageTests.cs
+++ b/OptunaTests/Storage/RDB/StorageTests.cs
@@ -13,6 +13,7 @@ public class SqliteStorageTests : IClassFixture<CreateStorage>, IDisposable
     {
         private readonly string _createFilePath = @"TestFile/created.db";
         private readonly string _existFilePath = @"TestFile/sqlite.db";
+        private readonly string _hitlFilePath = @"TestFile/hitl.db";
         private readonly List<string> _tempDBPaths = new List<string>();
 
         [Fact()]
@@ -86,6 +87,15 @@ public void GetAllStudiesTest()
             Assert.Equal(3, studies.Length);
         }
 
+        [Fact()]
+        public void LoadHitlDBTest()
+        {
+            var storage = new SqliteStorage(_hitlFilePath);
+            Study.Study[] study = storage.GetAllStudies();
+            Assert.Single(study);
+            Assert.Equal(DateTime.MinValue, study[0].Trials[0].DatetimeComplete);
+        }
+
         public void Dispose()
         {
             foreach (string path in _tempDBPaths)
diff --git a/OptunaTests/TestFile/hitl.db b/OptunaTests/TestFile/hitl.db
new file mode 100644
index 0000000000000000000000000000000000000000..1ad9cf1d4bb2130fd96c294099b9dd2cf33a5710
GIT binary patch
literal 122880
zcmeI5Yit`=c7SL27>X3dksmTGE0QOSy%u3p;S5PpvYRy(nU-lwa!gBEd+UH0kt2I-
zJ`~Q-iA)$>Dc)Tau+aed(JuDS0*ej0K(Id=6e$YqB0t&y3vAF91&VHp0J~dYn;)B9
zqzO<2Zh_uA@8Ls~6_K^wGqB}3b06oP@0_{!&b`*m<xBITEHJB;YKfPb7%@nYB#~km
zf*=;q-!b%8KWKE~(gpM{X*q9qx<E`^yz9o9>4!MaLHeQp&4G{m9saa;)%R}S1<z+x
z!SlB3=hTpscfCpe$~jIxARn}=?kT^1X^096r%6IA7lhZPSBuCqIld-W6gekXMZTC5
z%d$`{2?dcyiMRP;O^|YI+oS`V>Ajxd(WB(O1({zd3Tj5RnDu<$Y&Jc!lxCJ@UYt)e
z))Z#k=e5W=vA|>&m(p|TEVFoViCJ8ppFhFqS=uC4R&EM;S-dT@EUL7IIXi!GW(n7%
zh&g$EO<-Q0$<Cge$&M$(HeD}eGYd1>tIUP;Rc74YwlJ<?c`<WoIjtv&g%ga?044qG
z#cVn=w}{JY#l=FH$)?Yyv+2dz^kvn4$*dsk3n%wc!3#&Xc8%Q|s<eOe#GvYc5sL%X
z_$ptL)TXQFds;X^O~DRO&bEslBTx&J`H~4S!E%cAYElFAf{0tQQj^6>Id@a4l$oXU
z6~!Gk*m^tKU^cbxob#T}oE0@j)T`3o%}l@(Javk^7q)Pg)+Jde<#<^&PSB7yU8Y;m
zZ^~re35`jQ;+fDbVLfC-w(b-)=-Y!=L#2h@Hl9$l?AQqlG!^7eZ5`~5Z87}OlrXq?
z+V2S_ljOZoi)(6<P;GKd!^MFXZfVG3I>nyQE0;8B?TSM(161&p<kk+cx5RKq!{xx0
zek#ZglQm^b5noqF6)7jlwZb}rrUaVg*T82M&!n#~&AFJ1i$*7@mke(n^m&5A!{ohw
z)6MD)C-pZw5_PW~MvZc<v?5gXAp`enx+?oMG!Pp1)0BOrD4;Z1ED6XwzA7_k&=9wj
zSxDo$jHG;}w1x&o!Io<4_0*dWjS;w<b@0&JV;em1MNvTJ8L7VT=J`Igb2_e|QB#_3
zls1>WHh66^VVbRz+T96iZga%O#_g<gYOB|FFX;MCFs(Z$J-s8$1@Bh9Q|rc{+o4T@
zZ!<-yz0+ZfZyN3zwQR#hPYb^^WHG&BPw16TnzVMuBN@+D-BU|=x<BkKl=?Q$yF9^2
zguFLr@kT+c;`w8xEU9&wvb%*3%v2M<ajhMBBSX8cMAdBGF18t|F~8J%CR?hlGik5@
zwWp0wj5>GT?VNT~!OM|$!$w0(j9bJ&AyMdgs}DbOZCrCIli1C=;+5M%Rl*ZRvAkNb
zp1W+`u%=*7SmkzZkn%T#5}(tu>NIiJR1{aLe0AMO(w_~u#H0eq2Dw3%l415-diDY{
z-jMVHizfFs9jFHwAvb7!P{e3ZAFhpxcp9x;acUN7j~K@I*jxY)k=j*#D8TiEH~ge0
zID(W_i~vWPw44qbK%=<cwYP~roNqnXG}-SIgUGMJ{sHupr2m0Hf8YQDKmZ5;0U!Vb
zfB+Bx0zd!=00AHX1fC26&y!9<C|4qQF(ASTlkt2s&qnfWf{ny^el;?c7org^!N-z$
zK0le~l0IY?N&h2({=fkQfB+Bx0zd!=00AHX1b_e#00KY&2s|MKo_7k~M|u8N_y4~j
z=r5iS1EHBf00;m9AOHk_01yBIKmZ5;0U!VbfWWp0_(&H)2K}*##6(nm{{M`iKigJO
z$OHs{01yBIKmZ5;0U!VbfB+Bx0zd!=JP8B_NH;O+?OVt!W)?EvOsoI@{~@8ip6^L8
z0NMxyfB+Bx0zd!=00AHX1b_e#00KY&2s{D-m&@Dd#ryvb`aVJbCHese5C8%|00;m9
zAOHk_01yBIKmZ5;0U*$I0*4%K!h38~u9eHicMd|)36`CRhF&Hq!W-V$bDKwBfkPj1
zQ(pHk{c$ME7sQ&xhR|14)KktpjhUx$e0ok0uiucByy__zdIj(QJLr!H`Xl<&t{Vsn
zfB+Bx0zd!=00AHX1b_e#00KY&2mpayCa~A#Jx1Er5*+AK7=2&ex`KfB|DE(QLH`^5
zGxQG}KmZ5;0U!VbfB+Bx0zd!=00AHX1c1PH30!xg&HBW~v9+qODpZAXUO1Vrl-4R`
zp)A)!m72U(lXLR=nh-k4g!rl~uJU;q@6hY#xm&_IPCHjC@#TnEj>tEJ$b6-;#@yy5
zfywi0a;++a?vCL9F_5G!ddj)$LRqNtvM~7^`b~fD%#bBflybTxi+oY8)&#u&@1)-$
z=y&K}(;sZtK*$FKfB+Bx0zd!=00AHX1b_e#00KY&2y~0Uu*;hu^#^$Cnu7C?%bT>O
zn5zJeF_(A7Ybn&Q27vefDViYYe?cn%8}!TcaU{S21b_e#00KY&2mk>f00e*l5C8%|
z;3*>zraT1c9ho8A+2zH>%;Fpu<>HYj7vZKDHhPkao{S|X5|goMZaVDNvbwg&8jo>Y
zj19ZAtj;a6qMTESXxOP`b!?H9olZ{0*>Q)5@Zz>^kuy4-NG7MpNe|K2HYYoEGR{qK
z@u_4ij`#m5`rirqzv=&?|C9cd{sakd00AHX1b_e#00KY&2mk>f00e*l5C8&C8UdHn
zOH%lU8~<?OA5Q$k;dFYH_y1FYX@dT1TBJt<{}lK(65s#=KmZ5;0U!VbfB+Bx0zd!=
z00AJN6F5(~2{Ln)>hLS-g_X&;FvTS!Nj8y>#JQ*tnNCc{BZVjzTbbtBcr;%Kop&pB
zxjWRw@hkjff}M=S6R~(C9!<m}EBR<FGM!)H5<;Avni8f%=Uqx&t`2p@rzYctXlx~t
z$fM2vcq~5|nd0Kp5k4MECX%Zw(^HeEE~iqLvqN1gQ!6ncDdZzulr2Q!d3HLoGR@{A
zldI9mLUej68J&)Y&ZA$|N4y*z>Oxha2Jxs}!X)Cw3&^}^Y&F8KCXxbQKtJ+Rp$z`b
z{>;@5RjnkG92bu#BMFv8CQc=j5%j+pga}_i=Toc61UsD%sr&y&2>N6CZ|Jw^GM%B1
z=q`qTfdCKy0zd!=00AHX1b_e#00KY&2>gE{aKuGs$PNn~l#;2#3Wi(B)M07DrDW=`
z=HOH^by!Srgk0W?ck5LG<@f*l^921zf!7B9%Kxc<90_m$0U!VbfB+Bx0zd!=00AJd
zQvw?=QWQaoo5v{q_1@CSZEcIzubD3d7Yo<W3&F32wo~vLdX@OKP)RHa_#NYFIkCiF
z7oJ}$Usn^+JIN~r5lbhTa;;dz1y;qPQ07b40=dM5Qsi!E<3+b>gxfS?Tl=xCjMz@W
zT{I$Y8sSonaG6GIYa_Uo5!)%ai$=suBhcIBaX2|mBet~z-O7mV6x>B4IMWD+YJ|fy
zVq06^t&G@C!Cf?hHH?@c(R==pCrlf*wddZ-hV2yGMH`~J4a)w1;O_|fL;5f1JUtQk
z5(#hs0U!VbfB+Bx0zd!=00AHX1b_e#cnk@|U8G1p;^G>m6nezPEVokV5f_hKN})$w
ztZ^!Z9&vHR!MVJm_t6$3+{m9K{SbR~jD8px9Qfft-2a~cWdBe5=X}5PiQeCNZ})xK
z_eS54=WS1zdWV{Hzwgeve&Z6HpEz$he((5}V~~7{93_5$tJwXc{w#Vu;)rKsnac77
zu_nb*XWmz|)I)f!5`QG|Y_Y=2XGBS^iYql)tdx~6DaxuSNGMA^B+0@WI*CrO=qroG
z%4_JHjZQ?7a6`O)Ly=UmSh<d*RlX<*ckjv!R!$nqxl_H+T0d+znN7WP{}<@^uoue9
zV_3OkW6pg}KxAZ&cwnl{lsj>@;6rRR>K5j#75QZJ?%m?3ia4$5W9N2JUBap@inP_A
z(a^fpXo{yUNilT9O{Lw7ruv9oc`TLvU=<zLd!qc1T{)Lp-iIxZ^+frwT{)Y|e2#VZ
z1bg`)R*oXtrAPEzrp?`m=pfcdZlpDRY<?HjHAS?1K-ISF(jxkxsjYjVEDzbW#t!#F
zYkfb~ipB!XRxXv1dKO0YeRkz+>N4(>d($hI_Nu(+oLUT5P2SxI;XSIlw5E>bc2Qk(
z2oI{-mYrG%KW}R5UI^D|&7YdqSn4S5j8|8Cp<E8wP3C%I@_^lBHud%So`rDPkCmft
z*r9jB-!VydBZm7`#A!`mm%Cw~=1_+g!&9blU5sI`=1@&*EOq&}ID~sMqv*3M=Tb|b
z<KDP8GYXGgIh$I#-?LCIp?Ai6aVYDN{9V)8U5Mmc=)Ln^JfTq4v4vgK*3=o_L2s`2
z;xSgAAYbtJjO!irDtwFXSnAZfJqxHi_}%)Z-CXJ$64u?58R{MMwtkClHpOA&U7uN?
z$LP^#@&5mj08P;E)9=z>(EmYyg#IT$iO$hKqW_%!Q@TzM)BW@%dX`Sm#{z#JcrWlj
zfj<O(9r)+KtATvr$ARw$9t8d*FdCo(%YnJTbl|x1Yz{ww01yBIKmZ5;0U!VbfB+Bx
z0zlw#CotebTNjkJu5rXFvCpZJwk{B|O0j3H63192_OK%9+lgaVi5*oXt<GnxQf$O3
zafhrDJFH0hhR#8&#0FJKtMh<WiVayMZogGx_bHOTz`oZiv3pcWt8>sQ#b~R<1*{S~
zph)_Pr{5~E{i>wZ>9a~PuT|putP<<-yU=Qo<|4`>ux>@rDs)+dnA0L~j(${uSIx%a
z-~T5DANR0?_5lGP00e*l5C8%|00;m9AOHk_01yBIUxfhP|A*)QuR;*Y0s$ZZ1b_e#
z00KY&2mk>f00e*l5P19v!2bW^?;~g-5C8%|00;m9AOHk_01yBIKmZ5;fv-vc_W!>s
zK`0LdfB+Bx0zd!=00AHX1b_e#00KbZ@h3147$f>UpAqz{v^(%M|C<9J_dEP)@2c<J
zz6+kusDkHh*UzaTC+~Wb{FQT@d_X>U{B3$-TNoIl3c_iU5X%MOb?McjC<{5hCRY?W
zhdyY)7jt4+7OEwoAo3{jHeaj>QjTq#bO2SkCwTNId2d1HSBip~Q7vXY-#430&n%^x
zrI{D!(~LER8TWZDa!xETnZ>2_Tsq4vUR+`pm*?kCFnX3YiItU`LS7bc3oVN(tzpj2
zUz}OOH7Q~af4P=<c_ur1ZYDdP4BK?Ql+7&6WUn$8(pQ;rd)vaehULY~rRB7qBo<CE
zMgx@evlp}J%-kX_uN4;yVJ4eCo6e>eXVaHe`z5o2urHk4M+Gk&-P$#FZ>ZA#z?kbz
z#Q`H02dwc`zJxzmfgGxy?`h!xH3d6BIomFJj6f}bzmQ=-Ot73{y_(bjy<qu#M((Cm
zDKksyD~da8u=RGd!E9>XIp;l{IV)<6s8^-EfidTJ@YE^tUf9A}T1TItDCKzLV<0N>
zrpt5-`c0Y4JE1Y@Q9Kj6C9H><oT3JOd+@E>jr6whgra4~PFSF+Ab)D>U~gn#_@gOd
zFfc|w2qu%{y-|y6YLZZGa!kX;ffjCQ$YMIhp3p0oG->UMLox$Y@Rj7&4zahya7V-C
zz?FU~$PSY=WlRxYS4R~oC&{(KI)bJIn&j8OXBN+-uQ1KIn2U=>C#jbVZyxk{g2Th)
zy?)cpY9A-{H#-t_uN_8>a;>x?RP`YP_iDN-`!zHW8u!zbeWWO$G#Pyd9hrwdi^QBk
zL)=nkA&u)YlJb?(8X6b{TdJ+sQ*S=)Ub7A!dV6ex2fio@$UGy}7v4PI=TSPR;|dxz
zrRhd#bJ=Ty*CrFD**dA+ouKA6M{EpbXPr}9y|#Nn*N46fguB3|&Ph-22y?-^Rqxcg
zG3a(^li=G-Q68mtI&ASx!(F46ZMf)Z;g^OirdR9<z4A$u*6w&D<JqcvY6(yGhrNYT
z-{yIjCm4y4_vS3#D2P=&f2@=xwJuY3xA1|PYT`GpwIgq2XxEjfn$6qAHX}9WmwL}+
zOSN?-4HlsGwDE~i=g#kx({3twInr*}XlRLXix?;*3Oz~n;isvMYfcZI#BSCVuiO@@
z67mLm7Fn%W&s{ceSW~bkta3XyNckH=iO*?Sb(*+qDvB#rzPfHC>CXmSVp0KQgWRA>
z$uN5^J$r!}Z%BH9MU(rR4%7pnFD%gdpor0+K3p3W@ibby;?ykE9x;sZvAF;qBDJgf
zP=M<RZ}>@1a0Dr<7y*tnX*nG>fJSk>Yi|>MINy4%X|mrb22tes!ULX%M8N$MBJi_-
zG;qxSul+ynU-ON7|IqhxpOgBY=WpFVp}zUVK2Jl#fdCKy0#6NrjqpKF@c40Z)2j>~
zd{HQ^h<SZXY!F9mgGoc8bwEZBTE?s=#@U~sW-l&YUdqm(B|oO2hTPh%JkxU2MfIVP
z<%MA?c<Fe%$wy;lY{P|THpdPq6TvssaZ-H-yCI;*xD|nywY4)-9<~|Vm>XN$aIM`8
zM1R=R=N`6E)X--<EZUN7G@A9<CVIM_rrDj5&|yXLba1Q5U4wRGIl!<$I)v^DWpa0E
zhzjoVs`DEM_IrY-Pm|w1rNpUbQuE4n+k~MO?rgF0ZThu2aYqiuU#xBE`R4k~73=1-
zM_s;dQA5LXfgTkn(4<mW+i}qBco};$y;pexfPDmIBV*?d*y;NA=7~Yo0kDsNHo-dX
z*X;5V_GTuaF5toL0@_Y%y@028QMLs<<)VEnZ5J1_H&6T3wL92ZKuaXnrRnWD1AhPi
zsd+d6Lx2Df00KY&2mk>f00e*l5C8%|00^`t0Kfm=77Zi-0U!VbfB+Bx0zd!=00AHX
z1b_e#cxnjX{eP1Ff<S-Z00KY&2mk>f00e*l5C8%|00;m9AOHlOA_6|rF?u^T!A(Rb
zc)b4)&;L)6bHNlK00e*l5C8%|00;m9AOHk_01yBI8i9W2s8@gf$NT@!5<ej5dvssm
zeqeCmhXZl{d;XLCKkc9M{n96Tf9Jj3_hsK3eM6qNJz?q{YSR6_JL~$5OK^VTyyf`4
z<6DkF@-1={Rne8B{;Y=}M?4$LRF*G@H7S-l^S+{}9>Om?44q^`XNwhHK4W=-c?i9s
z!hGd7%2E&Em*$|8=md+>ij~*UIUAjbBH@O3{e~i`VzF`^NvnKO67JrW8LXT%lyj$g
zp|yV4ZZeyC>HaU!@nJ8Nm&dSj$HtudoPfy49Pz+Zn<;nVY{7@vYSb;vSu66%=-s=;
zQ5A7o)5p&3qPm1tTNG)lKck^_tI-rsU6Nwxh?`2g7ftmMyYg5n`@t$YuJ=UwA-i%e
zwY(2o9_xwnVY_lRmH8a&?g{qtL984_v`dfZw@jP65z#@ckK9OW`q=y~s%wg9`GBfz
z*`-DFK~r1zLRlWNYmFW5h1U9htQCy~nyp+aBlRqd>ig`<+0<p+DfgyVF6~u$&pEXi
zuA02N5yE>^b!kl<%k84N<`5oKwJkff5Psg&*1Zs})0#gut+CWm+!?Q~_CmQFu$#>F
z#^eFJ$!zND^F0gUvL7o)-LOONhQDKy?nVsvtBBK@zAkseKFy&HErzE|<GL8bUd^GJ
z)>!KDZ*d6sW=7FxSI(uDKF7UrZ)Ox8yK*+QbiZezT%tUL7l*PQ$=@}d-GxZL<;LpJ
zghExv7IslvQ)hg~g_WT(R-YhW@b`@C9j8rqEOqMLo(0q$hfOz^`i6vc_hg28hqUQt
zQyfO#o0$cE{&xm`M9^>0L+BqkfB+Bx0zd!=00AHX1b_e#00KY&2>jm>C?CPAJ!rv&
u(pOymY!}x+*yc^i=deDs;-cwev%9FSY00G?($=!HE$(>g{MUN6iub=r>aT48

literal 0
HcmV?d00001