Incorrect Gemspec for Rails version?

[hle-skillz]

I think this makes your gem require at minimum Rails 5.2:

rails-sharding/rails-sharding.gemspec

Line 25 in 7e61a8f

spec.add_runtime_dependency 'rails', '~> 5.2.0'

Contrary to the README that says it should support 5.0, 5.1, 5.2.

Based on docs:

The specifier ~> has a special meaning, best shown by example. ~> 2.0.3 is identical to >= 2.0.3 and < 2.1. ~> 2.1 is identical to >= 2.1 and < 3.0. ~> 2.2.beta will match prerelease versions like 2.2.beta.12. ~> 0 is identical to >= 0.0 and < 1.0.

I think you want:

spec.add_runtime_dependency 'rails', '~> 5.0' 

[hle-skillz]

Darn, never mind looks like aeac860 added flush_idle_connections which did not exist in 5.1.7 so this gem no longer supports Rails 5.0 or 5.1.

[hle-skillz]

@hsgubert Would it be viable to guard flush_idle_connections with a respond_to? to support older Rails?

[hsgubert]

Hello @hle-skillz, I believe this gem has past versions (properly that support Rails 5.0 and 5.1.
I'm not sure if it is so easy to make a version that works for all versions.

Are you sure this is the only thing that needs to be changed? We might need to compare with previous versions that supported rails 5.0 and 5.1

[hle-skillz]

In the release that bumped gemspec dependency to Rails 5.2 I only see the flush addition:
aeac860

but I guess respond_to? flush_idle_connections would only let you move this back to 5.1:

spec.add_runtime_dependency 'rails', '~> 5.1' 

It'd be much more difficult to track any breaking changes against 5.0... and it looks like that might've been a breaking change: 3552ba0#diff-b98f5a9c3ac583929bb3f59e62847c56ac72ff86182f5b6dddc5be9ec88aec7cR41