Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class '.close' of bootstrap breaks layout of code snippets when you use _close.scss of Bootstrap. #7

Open
Mishurin opened this issue Mar 13, 2015 · 2 comments

Comments

@Mishurin
Copy link

I think, it is reasonable to add some styles for .close class since it is used for styling in rainbow. For example,
.rainbow {
.close {
float: none;
font-size: inherit;
font-weight: inherit;
line-height: inherit;
text-shadow: none;
opacity: 1;
filter: none;
&:hover,
&:focus {
color: inherit;
text-decoration: inherit;
cursor: inherit;
opacity: 1;
}
}
}
This means, that in scope of .rainbow we have defined styles for .close class.

@Mishurin
Copy link
Author

Otherwise you will get broken html code examples as I got.

@htanjo htanjo mentioned this issue Mar 22, 2015
4 tasks
@htanjo
Copy link
Owner

htanjo commented Mar 22, 2015

Thank you for reporting!
Actually we can prevent the layout issue by overriding with .rainbow .close { ... }, but I don't think it's perfect. (see: ccampbell/rainbow#101)

I'm planning to switch the syntax highlighting library itself.
I will choose a new library that uses high compatibility class names, like .some-prefix-close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants