Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer path normalization breaks directory content transfers #215

Open
JoshKarpel opened this issue Apr 29, 2020 · 1 comment
Open

Transfer path normalization breaks directory content transfers #215

JoshKarpel opened this issue Apr 29, 2020 · 1 comment
Assignees
@JoshKarpel
Labels
bug Something isn't working

Comments

@JoshKarpel
Copy link
Contributor

Because pathlib.Path objects don't store trailing slashes, the mode of transfer_input_files where you put a trailing slash on a directory to transfer its contents can't be used with HTMap.
@JoshKarpel JoshKarpel added the bug Something isn't working label Apr 29, 2020
@JoshKarpel JoshKarpel self-assigned this Apr 29, 2020
JoshKarpel added a commit that referenced this issue Apr 29, 2020
@JoshKarpel
group user file transfer tests together; add xfailing tests for #215
8d738bc
@JoshKarpel JoshKarpel changed the title Transfer path normalization doesn't allow directory content transfers Transfer path normalization breaks directory content transfers Apr 29, 2020
@JoshKarpel JoshKarpel mentioned this issue Apr 30, 2020
Merged
3 tasks
@JoshKarpel
Copy link
Contributor Author

Given #216 , it should be possible to add a transfer_contents_only keyword argument to a TransferPath that captures this behavior. It's not clear to me whether the trailing-slash convention works with non-Condor file transfer. Need to investigate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshKarpel JoshKarpel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshKarpel