feat: support google ads v14

htdangkhoa · Nov 11, 2023 · db08223 · db08223
1 parent 73a5d8b
commit db08223
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 17 deletions.
diff --git a/src/lib/Customer.ts b/src/lib/Customer.ts
@@ -6,7 +6,7 @@ import { CustomerServiceClient } from '../generated/google';
 import {
   ListAccessibleCustomersRequest,
   ListAccessibleCustomersResponse,
-} from '../generated/google/ads/googleads/v13/services/customer_service';
+} from '../generated/google/ads/googleads/v14/services/customer_service';
 
 export class Customer extends Service {
   protected get callMetadata(): Metadata {

diff --git a/src/lib/GoogleAds.ts b/src/lib/GoogleAds.ts
@@ -12,7 +12,7 @@ import {
   SearchGoogleAdsStreamResponse,
   MutateGoogleAdsRequest,
   MutateGoogleAdsResponse,
-} from '../generated/google/ads/googleads/v13/services/google_ads_service';
+} from '../generated/google/ads/googleads/v14/services/google_ads_service';
 
 export class GoogleAds extends Service {
   private customerOptions: CustomerOptions;

diff --git a/src/lib/constants.ts b/src/lib/constants.ts
@@ -1,5 +1,5 @@
 export const HOST = 'googleads.googleapis.com' as const;
 
-export const VERSION = 'v13' as const;
+export const VERSION = 'v14' as const;
 
 export const FAILURE_KEY = `google.ads.googleads.${VERSION}.errors.googleadsfailure-bin`;
diff --git a/src/lib/utils.ts b/src/lib/utils.ts
@@ -1,5 +1,5 @@
 import { credentials, OAuth2Client } from '@grpc/grpc-js';
-import { GoogleAdsFailure } from '../generated/google/ads/googleads/v13/errors/errors';
+import { GoogleAdsFailure } from '../generated/google/ads/googleads/v14/errors/errors';
 import { FAILURE_KEY } from './constants';
 
 export const getCredentials = (authClient: OAuth2Client) => {

diff --git a/src/tests/google-ads.spec.ts b/src/tests/google-ads.spec.ts
@@ -1,11 +1,11 @@
 import { status, Metadata, ServiceError } from '@grpc/grpc-js';
-import { AuthenticationErrorEnum_AuthenticationError } from '../generated/google/ads/googleads/v13/errors/authentication_error';
+import { AuthenticationErrorEnum_AuthenticationError } from '../generated/google/ads/googleads/v14/errors/authentication_error';
 import {
   ErrorCode,
   GoogleAdsFailure,
-} from '../generated/google/ads/googleads/v13/errors/errors';
-import { RequestErrorEnum_RequestError } from '../generated/google/ads/googleads/v13/errors/request_error';
-import { GoogleAdsRow } from '../generated/google/ads/googleads/v13/services/google_ads_service';
+} from '../generated/google/ads/googleads/v14/errors/errors';
+import { RequestErrorEnum_RequestError } from '../generated/google/ads/googleads/v14/errors/request_error';
+import { GoogleAdsRow } from '../generated/google/ads/googleads/v14/services/google_ads_service';
 import { Status } from '../generated/google/rpc/status';
 import { FAILURE_KEY, QueryBuilder, VERSION } from '../lib';
 import { GoogleAds } from '../lib/GoogleAds';
@@ -148,7 +148,7 @@ describe('searchStream', () => {
       const { value, done } = await stream.next();
       if (done) break;
       const results =
-        value.results?.map?.((result) => result).filter(Boolean) ?? [];
+        value.results?.map?.((result: any) => result).filter(Boolean) ?? [];
       campaigns.push(...results);
     }
 

diff --git a/src/tests/protos.spec.ts b/src/tests/protos.spec.ts
@@ -1,7 +1,7 @@
-import { CustomerServiceClient } from '../generated/google/ads/googleads/v13/services/customer_service';
-import { GoogleAdsServiceClient } from '../generated/google/ads/googleads/v13/services/google_ads_service';
-import { Campaign } from '../generated/google/ads/googleads/v13/resources/campaign';
-import { AdvertisingChannelTypeEnum_AdvertisingChannelType } from '../generated/google/ads/googleads/v13/enums/advertising_channel_type';
+import { CustomerServiceClient } from '../generated/google/ads/googleads/v14/services/customer_service';
+import { GoogleAdsServiceClient } from '../generated/google/ads/googleads/v14/services/google_ads_service';
+import { Campaign } from '../generated/google/ads/googleads/v14/resources/campaign';
+import { AdvertisingChannelTypeEnum_AdvertisingChannelType } from '../generated/google/ads/googleads/v14/enums/advertising_channel_type';
 import { MOCK_ADDRESS, MOCK_CREDENTIALS } from './test-utils';
 
 describe('CustomerServiceClient', () => {

diff --git a/src/tests/test-utils.ts b/src/tests/test-utils.ts
@@ -1,8 +1,8 @@
 import { credentials, Metadata, ServiceError } from '@grpc/grpc-js';
 import { google } from 'googleapis';
-import { AdGroupStatusEnum_AdGroupStatus } from '../generated/google/ads/googleads/v13/enums/ad_group_status';
-import { AdGroupTypeEnum_AdGroupType } from '../generated/google/ads/googleads/v13/enums/ad_group_type';
-import { ListAccessibleCustomersResponse } from '../generated/google/ads/googleads/v13/services/customer_service';
+import { AdGroupStatusEnum_AdGroupStatus } from '../generated/google/ads/googleads/v14/enums/ad_group_status';
+import { AdGroupTypeEnum_AdGroupType } from '../generated/google/ads/googleads/v14/enums/ad_group_type';
+import { ListAccessibleCustomersResponse } from '../generated/google/ads/googleads/v14/services/customer_service';
 import {
   GoogleAdsRow,
   MutateGoogleAdsRequest,
@@ -13,7 +13,7 @@ import {
   SearchGoogleAdsResponse,
   SearchGoogleAdsStreamRequest,
   SearchGoogleAdsStreamResponse,
-} from '../generated/google/ads/googleads/v13/services/google_ads_service';
+} from '../generated/google/ads/googleads/v14/services/google_ads_service';
 import { AllServices, Customer, GoogleAds, Service, ServiceName } from '../lib';
 
 export const MOCK_ADDRESS = 'googleads.googleapis.com';