Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow ./GoogleAds import and add long #119

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

boredland
Copy link
Contributor

@htdangkhoa htdangkhoa merged commit 2c5c647 into htdangkhoa:main Nov 27, 2024
3 of 6 checks passed
@boredland
Copy link
Contributor Author

little follow-up question @htdangkhoa: as in the README the only import used is GoogleAds, is there really a need for all those exports in src/index.ts or should the main entrypoint of this package just be the file GoogleAds?

@htdangkhoa
Copy link
Owner

htdangkhoa commented Nov 29, 2024

hi @boredland, thank you for your question.

I think this is necessary, because GoogleAds only loads Google Ads Service. In addition, Google Ads also has many other services such as Feed Service, Label Service, ... and opening it up as a way for different uses by extending the Service class.

Other than that this is identical in usage:

import { GoogleAds, ... } from '@htdangkhoa/google-ads'

instead of

import GoogleAds, { ... } from '@htdangkhoa/google-ads'

Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants